Repository navigation
refactor(ui): array.from instead of spread over node lists - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the spread over NodeLists and Sets in the shared ui-std blocks with
Array.from(...)(7 lines insrc/main.tsx):paintActiverows,openactive row, the Tab handler'sfocusableandpagelistspersistHiddenColumnspersistHiddenCategoriesrerenderKeepingFilterFocusWhy
The owner's IntelliJ checks
src/main.tsxwith TypeScript 5.9 defaults (ES5 lib), where[...document.querySelectorAll(...)]is TS2461 and[...set]is TS2802. Stocks PR 45 already made this change, now the shared blocks in the workspace match it and every repo gets the same lines. Behaviour does not change:Array.fromover a NodeList or Set gives the same array in the same order.How it was checked
bun test(exit 0)bun build --target=bun scripts/update-data.ts --outfile=/dev/nullandbun build --target=bun src/main.tsx --outfile=/dev/null.claude/tools/etfs/tc/check.sh(esnext + ide modes): 67 -> 64 error lines (TS2461x1 TS2802x2 gone), nothing newbun run build, then the headless Chrome tests of ui-std (--mute-audio) againstdist:brand-uitest43 passed,columns-uitest19 passed,categories-uitest19 passed,kbd-check15 passed, wherekbd-checkdrives the changed lines (ArrowDown, ArrowUp, PageDown, Tab and Shift+Tab out of the Columns panel, saved hidden columns and asset classes, filter focus and caret kept); each run ended0 failed; console errors: none