Repository navigation
refactor: move jobs out of DaprClientImpl - #1911
Open
javier-aliaga wants to merge 1 commit into
Open
javier-aliaga wants to merge 1 commit into
javier-aliaga wants to merge 1 commit into
Conversation
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the extracted jobs client and its delegating integration.
No open issues 🎉
What changed in this PR
This pull request extracts the jobs building-block implementation from DaprClientImpl into a package-private DaprJobsClient, preserving the public API and existing RPC fallback behavior.
Changes:
- Added
DaprJobsClientwith job scheduling, retrieval, deletion, validation, failure-policy mapping, and fallback logic. - Added and initialized a
jobsClientdelegate inDaprClientImpl. - Replaced the jobs method implementations in
DaprClientImplwith delegations.
| File | Description |
|---|---|
| sdk/src/main/java/io/dapr/client/DaprJobsClient.java | Adds the package-private jobs client containing the extracted jobs API implementation and fallback behavior. |
| sdk/src/main/java/io/dapr/client/DaprClientImpl.java | Initializes the jobs delegate and forwards the public jobs methods to it. |
Review effort: Lite
javier-aliaga
marked this pull request as ready for review
November 17, 2026 09:24
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1911 +/- ##
============================================
+ Coverage 82.07% 82.13% +0.05%
- Complexity 3761 3765 +4
============================================
Files 338 339 +1
Lines 11544 11551 +7
Branches 1303 1303
============================================
+ Hits 9475 9487 +12
+ Misses 1561 1557 -4
+ Partials 508 507 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sixth step of splitting
DaprClientImplinto package-private classes, one per building block. This PR moves the jobs API.DaprJobsClientholdsscheduleJob,getJobanddeleteJob, plusgetJobFailurePolicy,isUnimplementedand the three request validators. The bodies are unchanged, including the fallback to the Alpha1 RPCs on pre-1.18 sidecars.DaprClientImplkeep their signatures and Javadoc, and delegate in one line.DaprClientImplgoes from 1,606 to 1,408 lines.Issue reference
Part of #1875
Checklist
DaprClientGrpcTestcovers jobs through the public methods. The 626sdkunit tests pass unchanged.