Repository navigation
fixes - #25
fixes#25AbhishekKumar9984 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates dependency versions in pom.xml, including upgrading CDAP, Guava, and Hadoop, and adds exclusions for Guava in several dependencies. The review feedback points out that the selected Guava version (32.0.0-jre) has a known security vulnerability (CVE-2023-2976) and recommends upgrading to 32.1.3-jre instead.
deepika-lalwani123
left a comment
There was a problem hiding this comment.
This depends on cdapio/cdap#16279. The currently published 6.12.0-SNAPSHOT still has Guava 13, so this PR cannot be validated or merged until that PR merges and CDAP (and Twill) are published. Please call out the dependency in the PR description.
|
@deepika-lalwani123 Updated the PR description to call out the dependency on cdapio/cdap#16279, and addressed all inline review comments. |
Depends on: cdapio/cdap#16279
Issue :
Resolved security vulnerabilities (CVE-2023-2976 / CVE-2020-8908) associated with older versions of
com.google.guava:guava(13.0.1) pulled in directly and transitively via plugin dependencies.Root Cause :
pom.xmlspecified<guava.version>13.0.1</guava.version>, andhydrator-common,hydrator-test, andcdap-data-pipeline3_2.12transitively brought in an older, vulnerable version of Guava.Fix :
<guava.version>from13.0.1to32.0.0-jre, pinnedcom.google.guava:guavain<dependencyManagement>, and addedmaven-enforcer-plugin(requireUpperBoundDeps).<cdap.version>from6.8.0to6.12.0-SNAPSHOT.Testing evidence: https://docs.google.com/spreadsheets/d/1Cw6Z_k3wlks7sAC4-Kg6FTIMRL7-zxLlsJIXvVJLrb8/edit?gid=0#gid=0