libs/dyn: remove what the load path does not use by denik · Pull Request #7203 · databricks/cli

denik · 2026-10-27T17:18:22Z

Changes

Remove the parts of libs/dyn that the configuration load no longer uses once #7098 converts the configuration to typed structs after loading:

dynvar (variable resolution) and jsonloader
the pattern trie and pattern strings, the read-only walk
the element-merge, override and select helpers of merge; merge.Merge stays for includes and targets

convert uses structvar to recognize a pure reference. 27 files, 3.4k lines removed, no change in behavior. (The unused dynloc and yamlsaver packages and two dead functions are removed in #7098, because the dead-code check requires it.)

Tests

The remaining libs/dyn tests pass, the build is clean, and nothing else imports the removed packages.

This pull request and its description were written by Isaac.

github-actions · 2026-10-27T17:26:23Z

Commit: a74e6afc5 | Workflow run

Regression test report

Selected 20 changed tests (limit=20, 1 not selected)

42 tests: regression=22 unreleased=0 coverage=20 failing=0

test	branch	main (`3aa5c96`)	latest (v1.23.0)
TestAccept/bundle/python/pipeline-development-deprecated/DMS=/PYDAB_VERSION=0.266.0	✅	❌	❌
TestAccept/bundle/python/pipeline-development-deprecated/DMS=/PYDAB_VERSION=current	✅	❌	❌
TestAccept/bundle/python/pipeline-development-deprecated/DMS=true/PYDAB_VERSION=0.266.0	✅	❌	❌
TestAccept/bundle/python/pipeline-development-deprecated/DMS=true/PYDAB_VERSION=current	✅	❌	❌
TestAccept/bundle/refschema/DMS=	✅	❌	❌
TestAccept/bundle/refschema/DMS=true	✅	❌	❌
TestAccept/bundle/strict_profile_match/default_profile/host/DMS=	✅	❌	❌
TestAccept/bundle/strict_profile_match/default_profile/host/DMS=true	✅	❌	❌
TestAccept/bundle/strict_profile_match/host/DMS=	✅	❌	❌
TestAccept/bundle/strict_profile_match/host/DMS=true	✅	❌	❌
TestAccept/bundle/validate/app_resource_duplicate_name_location/DMS=	✅	❌	❌
TestAccept/bundle/validate/app_resource_duplicate_name_location/DMS=true	✅	❌	❌
TestAccept/bundle/validate/includes/merge_failure_short_circuits_diagnostics/DMS=	✅	✅	✅
TestAccept/bundle/validate/includes/merge_failure_short_circuits_diagnostics/DMS=true	✅	✅	✅
TestAccept/bundle/validate/nulls/resources_container/DMS=	✅	✅	✅
TestAccept/bundle/validate/nulls/resources_container/DMS=true	✅	✅	✅
TestAccept/bundle/validate/references/resolved_invalid_map_value/DMS=	✅	✅	✅
TestAccept/bundle/validate/references/resolved_invalid_map_value/DMS=true	✅	✅	✅
TestAccept/bundle/validate/references/resolved_invalid_sequence_item/DMS=	✅	✅	✅
TestAccept/bundle/validate/references/resolved_invalid_sequence_item/DMS=true	✅	✅	✅
TestAccept/bundle/validate/references/resolved_invalid_sequence_items/DMS=	✅	❌	❌
TestAccept/bundle/validate/references/resolved_invalid_sequence_items/DMS=true	✅	❌	❌
TestAccept/bundle/validate/references/to_omitted_struct_defaults/DMS=	✅	❌	❌
TestAccept/bundle/validate/references/to_omitted_struct_defaults/DMS=true	✅	❌	❌
TestAccept/bundle/validate/required/DMS=	✅	❌	❌
TestAccept/bundle/validate/required/DMS=true	✅	❌	❌
TestAccept/bundle/validate/targets/scalar_rewrite_diagnostic/DMS=	✅	✅	✅
TestAccept/bundle/validate/targets/scalar_rewrite_diagnostic/DMS=true	✅	✅	✅
TestAccept/bundle/validate/variables/complex_default_nested_timestamp/DMS=	✅	❌	❌
TestAccept/bundle/validate/variables/complex_default_nested_timestamp/DMS=true	✅	❌	❌
TestAccept/bundle/validate/variables/complex_unknown_field_location/DMS=	✅	❌	❌
TestAccept/bundle/validate/variables/complex_unknown_field_location/DMS=true	✅	❌	❌
TestAccept/bundle/validate/variables/target_timestamp_shorthand/DMS=	✅	✅	✅
TestAccept/bundle/validate/variables/target_timestamp_shorthand/DMS=true	✅	✅	✅
TestAccept/bundle/validate/yaml_anchors/duplicate_merge_keys/DMS=	✅	✅	✅
TestAccept/bundle/validate/yaml_anchors/duplicate_merge_keys/DMS=true	✅	✅	✅
TestAccept/bundle/validate/yaml_anchors/inline_merge_mapping/DMS=	✅	✅	✅
TestAccept/bundle/validate/yaml_anchors/inline_merge_mapping/DMS=true	✅	✅	✅
TestAccept/bundle/validate/yaml_anchors/invalid_merge_sequence_member/DMS=	✅	✅	✅
TestAccept/bundle/validate/yaml_anchors/invalid_merge_sequence_member/DMS=true	✅	✅	✅
TestAccept/bundle/validate/yaml_duplicate_keys/shadowed_invalid_subtree/DMS=	✅	✅	✅
TestAccept/bundle/validate/yaml_duplicate_keys/shadowed_invalid_subtree/DMS=true	✅	✅	✅

TestAccept/bundle/python/pipeline-development-deprecated/DMS=/PYDAB_VERSION=0.266.0: branch ✅ | main (3aa5c96) ❌ | latest (v1.23.0) ❌

main (3aa5c96):

acceptance_test.go:1341: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1341
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1082
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:659
        	Error:      	Not equal: 
        	            	expected: "\n>>> uv run [UV_ARGS] -q [CLI] bundle validate\nName: my_project\nTarget: dev\nWorkspace:\n  User: [USERNAME]\n  Path: /Workspace/Users/[USERNAME]/.bundle/my_project/dev\n\nValidation OK!\n\n>>> uv run [UV_ARGS] -q [CLI] bundle validate --output json\n{\n  \"with_development\": true,\n  \"without_development\": true\n}\n"
        	            	actual  : "\n>>> uv run [UV_ARGS] -q [CLI] bundle validate\nWarning: The \"development\" property of pipelines is deprecated. Use \"mode: development\" in your databricks.yml instead. See https://docs.databricks.com/dev-tools/bundles/deployment-modes.\n  at resources.pipelines.with_development.development\n  in resources.py:7:1\n\nName: my_project\nTarget: dev\nWorkspace:\n  User: [USERNAME]\n  Path: /Workspace/Users/[USERNAME]/.bundle/my_project/dev\n\nFound 1 warning\n\n>>> uv run [UV_ARGS] -q [CLI] bundle validate --output json\nWarning: The \"development\" property of pipelines is deprecated. Use \"mode: development\" in your databricks.yml instead. See https://docs.databricks.com/dev-tools/bundles/deployment-modes.\n  at resources.pipelines.with_development.development\n  in resources.py:7:1\n\n{\n  \"with_development\": true,\n  \"without_development\": true\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,2 +2,6 @@
        	            	 >>> uv run [UV_ARGS] -q [CLI] bundle validate
        	            	+Warning: The "development" property of pipelines is deprecated. Use "mode: development" in your databricks.yml instead. See https://docs.databricks.com/dev-tools/bundles/deployment-modes.
        	            	+  at resources.pipelines.with_development.development
        	            	+  in resources.py:7:1
        	            	+
        	            	 Name: my_project
        	            	@@ -8,5 +12,9 @@
        	            	 
        	            	-Validation OK!
        	            	+Found 1 warning
        	            	 
        	            	 >>> uv run [UV_ARGS] -q [CLI] bundle validate --output json
        	            	+Warning: The "development" property of pipelines is deprecated. Use "mode: development" in your databricks.yml instead. See https://docs.databricks.com/dev-tools/bundles/deployment-modes.
        	            	+  at resources.pipelines.with_development.development
        	            	+  in resources.py:7:1
        	            	+
        	            	 {
        	Test:       	TestAccept/bundle/python/pipeline-development-deprecated/DMS=/PYDAB_VERSION=0.266.0
        	Messages:   	bundle/python/pipeline-development-deprecated/output.txt vs /tmp/TestAcceptbundlepythonpipeline-development-deprecatedDMS=PY3650477717/002/output.txt