Repository navigation
Record bundle behavior with faults for every DMS API - #7231
Open
shreyas-goenka wants to merge 10 commits into
Open
shreyas-goenka wants to merge 10 commits into
shreyas-goenka wants to merge 10 commits into
Conversation
Contributor
|
Commit: Regression test reportSelected 15 changed tests (limit=20, 0 not selected) 15 tests: regression=0 unreleased=0 coverage=15 failing=0
|
shreyas-goenka
changed the title
Collaborator
Integration test reportCommit: 0bb4e74
Top 6 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/test-bundle-dms-fail-open
branch
from
October 28, 2026 16:06
5dbdc5d to
9b95f43
Compare
shreyas-goenka
changed the base branch from
shreyas-goenka_data/shreyas/generate-omit-deployment-metadata
to
shreyas-goenka_data/shreyas/test-fault-glob-segments
October 28, 2026 16:06
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/test-bundle-dms-fail-open
branch
from
October 28, 2026 16:15
9b95f43 to
c769fef
Compare
Base automatically changed from
shreyas-goenka_data/shreyas/test-fault-glob-segments
to
shreyas-goenka_data/shreyas/generate-omit-deployment-metadata
October 28, 2026 16:50
shreyas-goenka
added a commit
that referenced
this pull request
Oct 28, 2026
## Changes Support `*` within a path segment and `**` across path segments in `fault.py` patterns. Both match zero or more characters; all other characters are literal. Compile each pattern once when its rule is registered.. ## Why useful for tests being added in #7231.
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/test-bundle-dms-fail-open
branch
from
October 28, 2026 16:50
c769fef to
15d2a7e
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/test-bundle-dms-fail-open
branch
from
October 28, 2026 16:56
15d2a7e to
e1c4557
Compare
shreyas-goenka
changed the base branch from
shreyas-goenka_data/shreyas/generate-omit-deployment-metadata
to
shreyas-goenka_data/shreyas/test-fault-glob-main
October 28, 2026 16:56
Base automatically changed from
shreyas-goenka_data/shreyas/test-fault-glob-main
to
main
October 28, 2026 17:34
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/test-bundle-dms-fail-open
branch
from
October 28, 2026 17:34
9e2109d to
1e09ad4
Compare
shreyas-goenka
commented
Oct 28, 2026
| === commands: get_deployment fault enabled | ||
|
|
||
| >>> bundle deploy --auto-approve | ||
| Warn: retrying after 500 Internal Server Error from GET /api/2.0/bundle/deployments/[DEPLOYMENT_ID] |
Contributor
Author
There was a problem hiding this comment.
these repeated warnings can be made prettier, we can iterate on them separately. It is good enough for now tbh.
shreyas-goenka
commented
Oct 28, 2026
|
|
||
| Destroy: 2 deleted | ||
|
|
||
| DMS API called: no |
Contributor
Author
There was a problem hiding this comment.
this is an important signal, shows whether the API is called or not (should we thus expect a warning in the output or not).
ilyakuz-db
approved these changes
Oct 29, 2026
ilyakuz-db
left a comment
ilyakuz-db
left a comment
Contributor
There was a problem hiding this comment.
This approach is fine, but maybe it will be simpler instead of making a suite for each API, do suite for each CLI command, and force all DMS APIs to return 500 there (and maybe also add some other Go error to ensure that any bugs won't break the direct engine flow)
@denik WDYT?
| @@ -0,0 +1,148 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Should we add init / config-remote-sync? I assume they don't interact directly in DMS, but is it possible through some shared code?
Contributor
Author
|
@ilyakuz-db if we make all APIs return 500, that'll not exercise all code paths since later flows can depend upon earlier ones succeeding. This is the most robust way to ensure nothing can break for customers. |
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas/test-bundle-dms-fail-open
branch
from
October 29, 2026 12:57
260fb4e to
0bb4e74
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Procedurally generate and run tests for all DMS APIs to ensure that the deployment history feature is truly best effort and DMS going down will not cause deployments to start failing.
This tests also ensure we display adequate warnings when the errors actually happen.