[denik]

Changes

Two acceptance tests for review comments on #7145:

• includes/nested_include_section: an included file with its own include: section is not loaded, but its entries stay in the include list (["a.yml", "c.yml"]). This is why ProcessRootIncludes appends Include[len(patterns):] instead of assigning the expanded files.
• resources/pipelines/glob_libraries_locations: a pipeline library whose path is a glob is expanded into one library per match, and a warning about each expanded library should point at the line of the glob. With bundle: read and edit the typed config in five mutators #7145 only the first one does, because the typed edit cannot carry the location to the other libraries. Marked with Badness.

Tests

Both pass on main. Before #7145 all three warnings in the second test had the location databricks.yml:12:13.

This pull request and its description were written by Isaac.

[github-actions]

Commit: c3b185dfd | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

4 tests: regression=0 unreleased=2 coverage=2 failing=0

test	branch	main (d3e5dde)	latest (v1.22.1)
TestAccept/bundle/includes/nested_include_section/DMS=	✅	✅	✅
TestAccept/bundle/includes/nested_include_section/DMS=true	✅	✅	✅
TestAccept/bundle/resources/pipelines/glob_libraries_locations/DMS=	✅	✅	❌
TestAccept/bundle/resources/pipelines/glob_libraries_locations/DMS=true	✅	✅	❌

TestAccept/bundle/resources/pipelines/glob_libraries_locations/DMS=: branch ✅ | main (d3e5dde) ✅ | latest (v1.22.1) ❌

latest (v1.22.1):

acceptance_test.go:1341: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1341
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1082
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:659
        	Error:      	Not equal: 
        	            	expected: "\n>>> [CLI] bundle validate\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[0].maven\n  in databricks.yml:12:13\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[1].maven\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[2].maven\n\nName: test-bundle\nTarget: default\nWorkspace:\n  User: [USERNAME]\n  Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default\n\nFound 3 warnings\n"
        	            	actual  : "\n>>> [CLI] bundle validate\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[0].maven\n  in databricks.yml:12:13\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[1].maven\n  in databricks.yml:12:13\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[2].maven\n  in databricks.yml:12:13\n\nName: test-bundle\nTarget: default\nWorkspace:\n  User: [USERNAME]\n  Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default\n\nFound 3 warnings\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -8,2 +8,3 @@
        	            	   at resources.pipelines.p.libraries[1].maven
        	            	+  in databricks.yml:12:13
        	            	 
        	            	@@ -11,2 +12,3 @@
        	            	   at resources.pipelines.p.libraries[2].maven
        	            	+  in databricks.yml:12:13
        	            	 
        	Test:       	TestAccept/bundle/resources/pipelines/glob_libraries_locations/DMS=
        	Messages:   	bundle/resources/pipelines/glob_libraries_locations/output.txt vs /tmp/TestAcceptbundleresourcespipelinesglob_libraries_locationsD4183128655/002/output.txt

TestAccept/bundle/resources/pipelines/glob_libraries_locations/DMS=true: branch ✅ | main (d3e5dde) ✅ | latest (v1.22.1) ❌

latest (v1.22.1):

acceptance_test.go:1341: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1341
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1082
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:659
        	Error:      	Not equal: 
        	            	expected: "\n>>> [CLI] bundle validate\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[0].maven\n  in databricks.yml:12:13\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[1].maven\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[2].maven\n\nName: test-bundle\nTarget: default\nWorkspace:\n  User: [USERNAME]\n  Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default\n\nFound 3 warnings\n"
        	            	actual  : "\n>>> [CLI] bundle validate\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[0].maven\n  in databricks.yml:12:13\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[1].maven\n  in databricks.yml:12:13\n\nWarning: required field \"coordinates\" is not set\n  at resources.pipelines.p.libraries[2].maven\n  in databricks.yml:12:13\n\nName: test-bundle\nTarget: default\nWorkspace:\n  User: [USERNAME]\n  Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default\n\nFound 3 warnings\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -8,2 +8,3 @@
        	            	   at resources.pipelines.p.libraries[1].maven
        	            	+  in databricks.yml:12:13
        	            	 
        	            	@@ -11,2 +12,3 @@
        	            	   at resources.pipelines.p.libraries[2].maven
        	            	+  in databricks.yml:12:13
        	            	 
        	Test:       	TestAccept/bundle/resources/pipelines/glob_libraries_locations/DMS=true
        	Messages:   	bundle/resources/pipelines/glob_libraries_locations/output.txt vs /tmp/TestAcceptbundleresourcespipelinesglob_libraries_locationsD3421757470/002/output.txt
FAIL

[eng-dev-ecosystem-bot]

Integration test report

Commit: c3b185d

Run: 40715729416

	Env	✅​pass	🙈​skip	Time
✅​	aws linux-2core-8gb	281	17	5:17
✅​	aws-windows-latest-4core-16gb	283	15	3:32
✅​	azure linux-2core-8gb	280	17	5:29
✅​	azure-windows-latest-4core-16gb	282	15	5:06
✅​	gcp linux-2core-8gb	281	17	5:16
✅​	gcp-windows-latest-4core-16gb	283	15	3:24

Top 6 slowest tests (at least 2 minutes):

duration	env	testname
5:02	azure-windows-latest-4core-16gb	TestAccept
3:34	gcp linux-2core-8gb	TestAccept
3:31	azure linux-2core-8gb	TestAccept
3:30	aws linux-2core-8gb	TestAccept
3:26	aws-windows-latest-4core-16gb	TestAccept
3:18	gcp-windows-latest-4core-16gb	TestAccept