Repository navigation
Reject unprefixed volume schema references during bundle validation - #7285
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 95a9959
Top 3 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Nov 2, 2026
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/variables/reference-typo/DMS=: branch ✅ | main (cd5c64d) ❌ | latest (v1.23.0) ❌main (cd5c64d): latest (v1.23.0): TestAccept/bundle/variables/reference-typo/DMS=true: branch ✅ | main (cd5c64d) ❌ | latest (v1.23.0) ❌main (cd5c64d): latest (v1.23.0): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unprefixed schema references in volume fields during bundle validation.
Problem
Fixes Issue #3566, which showed
${schemas.test.name}and${schemas.test.catalog_name}in volumeschema_nameandcatalog_nameand reports: "Validation is successful, only failing on deploy." The base fixture at3aa5c9607bff73d3fb18a4c6e63b9f03235f3de7also exited successfully while leaving both references literal.Change
bundle validateand suggest the matching${resources.schemas.*}path.Verification
go test -p 4 ./bundle/config/mutator -count=1passed locally at95a9959d951318eb1cfb6d64b879f790d76b8ce1. The regression test covers repeated references across two volumes, both fields, source locations, and valid prefixed references.go test -p 4 ./acceptance -run '^TestAccept$/bundle/variables/reference-typo' -count=1 -vpassed locally in both DMS variants. The new fixture captures twobundle validateerrors with field paths, YAML locations, and suggestions.go test -p 4 ./acceptance -run '^TestAccept$/bundle/resource_deps/resources_var_presets_implicit_deps' -count=1 -vpassed locally in both DMS variants. That existing fixture validates correctly prefixed schema references in volume fields.The acceptance tests ran locally against the test server. A live workspace deployment was not exercised.