Repository navigation
Regenerate cli.json and command stubs for immutable create-only flags (preview) - #7318
Open
janniklasrose wants to merge 2 commits into
Open
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
… (preview) cli.json generated by genkit from universe e4c1445cc07c302f22726b5c84854e4ab661ad18 (master + the deco/genkit change that emits is_immutable and is_crud_update), then generate-cligen, generate-refschema, generate-schema, generate-validation and generate-direct. With the template change below this, 15 flags for immutable fields disappear from 11 update commands across 6 services; no create flag changes. .codegen/_openapi_sha is intentionally left at the SDK's SHA so TestConsistentDatabricksSdkVersion holds; this branch is a preview to be regenerated once the genkit change is on master and the SDK is bumped past it. The instance-pools doc text and jsonschema.json launch-stage changes are unrelated spec drift carried by the newer spec. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
changed the title
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 6279755
Top 9 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Preview regeneration stacked on #7309: shows what
cli.jsonand the generated command stubs look like once the genkit change (databricks-eng/universe#2777642) is in the spec and #7309's template consumes it. It exists so the user-visible effect can be reviewed now; it must be regenerated for real (and this description's provenance replaced) once #2777642 is on universe master and the Go SDK /.codegen/_openapi_shaare bumped past it.Provenance of the committed
cli.json: built withgenkit update-sdkfrom universee4c1445cc07c302f22726b5c84854e4ab661ad18= current master (004d86d968ec4) + #2777642's genkit commit, using the spec built from that same tree..codegen/_openapi_shais deliberately left at the SDK's value (e70a2223…):TestConsistentDatabricksSdkVersionrequires it to match the SHA the pinned Go SDK was generated from, and no SDK release exists for the simulated SHA yet. That is the one place this branch is knowingly inconsistent.What changes for users
cli.jsongainsis_immutable(826) andis_crud_update(193) keys. With #7309's template, 15 flags disappear from 11update-*commands across 6 services — fields the API refuses to change after create, so these flags never worked. Nocreateflag changes;lakeviewis untouched (itsparent_pathis stillcomputed, see #5983).account disaster-recovery update-failover-group--nameagent-kit update-memory--session-id,--source-typeagent-kit update-memory-store--display-nameagent-kit update-session--parent-session-idai-gateway update-mcp-service/update-model-provider-service/update-model-service/update-skill--namedomains update-domain--name,--parent-domain-idenvironments update-default-workspace-base-environment--namefeature-engineering update-feature--filter-conditionfeature-engineering update-materialization-set--materialization-set-idfeature-engineering update-materialized-feature--materialized-feature-idThe changelog fragment for this user-visible change lives here (moved out of #7309, which on its own changes nothing).
Spec drift, not part of this change
Because the simulated spec is newer than the SDK's, the regeneration also picks up unrelated upstream drift that a real bump would carry anyway:
instance-poolsnode_type_iddoc text, andbundle/schema/jsonschema.jsonlaunch-stage/description updates (ai_classifyfields moving PRIVATE_PREVIEW → PUBLIC_BETA). They are kept so the committed generated outputs stay consistent with the committedcli.json(CI'sgenerate-checkregenerates from it). Expect these lines to differ in the real regen.Why the changes are safe
genkit update-sdk→generate-clijsonpost-steps →generate-cligen,generate-refschema,generate-schema,generate-validation,generate-direct.pydabs-codegencould not run on the generating machine (PyPI host blocked); if the schema drift touches PyDABs output, CI'svalidate-generatedwill flag it and it gets regenerated there.go build ./...;go test ./internal/cligen ./internal/clijson ./bundle/direct/dresources ./bundle/internal/schemapass.cli.jsonwithjq, stubs re-rendered) differs from main only by theinstance-poolsdoc string — the flag removals are attributable solely to the new keys.Tests
Unit tests above. Stacked on #7309 (template) which is stacked on main; depends on databricks-eng/universe#2777642 for the real regen.
This pull request and its description were written by Isaac.