Repository navigation
acc: match PROD_ROOT_DIR_ID with a regex in default-python/classic - #7324
Merged
Merged
Conversation
The script looked up the prod root directory's object id and registered it as a literal replacement. Match it by its position in the permissions path instead; this drops the extra get-status call and the jq/python workaround. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
Integration test reportCommit: a3214e9
Top 7 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Nov 3, 2026
Collaborator
Integration test reportCommit: 44f2eda
284 interesting tests: 268 FAIL, 16 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle/templates/default-python/classiclooked up the prod root directory's object id withworkspace get-statusand registered it as a literal replacement (add_repl). It used python because jq 1.6 rounds ids above 2^53. Replace this with a[[Repls]]regex on/permissions/directories/<id>, the only place the id appears.Why
A literal replacement rewrites the id's digits wherever they appear in the output: inside timestamps, UUIDs, ports and wheel versions. Every failure of this test on the dashboard in the last 3 weeks is that collision: 23 errors across both variants.
#7253 made such collisions practically impossible by giving testserver ids 16 digits. This PR removes the literal entirely, so the replacement can only ever match the permissions path. It also drops an extra API call and the python workaround from the script.
Dashboard tests: classic/DMS=/READPLAN=, classic/DMS=/READPLAN=1
+side of the diff)Note that http://127.0.0.1:[PROD_ROOT_DIR_ID]5 is used for initialization."cli_version": "[CLI_VERSION]+1[PROD_ROOT_DIR_ID]9783df6","created_time": 1[PROD_ROOT_DIR_ID]42371540,"created_time": 179266[PROD_ROOT_DIR_ID]051,"created_time": 1792130[PROD_ROOT_DIR_ID]45,"created_time": 179242[PROD_ROOT_DIR_ID]583,"created_time": [PROD_ROOT_DIR_ID]766033611,"nuid": "5ch3m4-w1dg-3t98-7654-3210[PROD_ROOT_DIR_ID]5432","nuid": "5ch3m4-w1dg-3t98-7654-32[PROD_ROOT_DIR_ID]765432","nuid": "5ch3m4-w1dg-3t98-7654-3210987[PROD_ROOT_DIR_ID]2","rowLimit": [PROD_ROOT_DIR_ID]"whl": "/Workspace/Users/[USERNAME]/.bundle/my_default_python/dev/artifacts/.internal/my_default_python-0.0.1+179341154774253[PROD_ROOT_DIR_ID]-py3-none-any.whl""nuid": "a1b2c3d4-e5f6-[PROD_ROOT_DIR_ID]-abcd-ef123456[PROD_ROOT_DIR_ID]",uuid: 7[PROD_ROOT_DIR_ID]faf-1ebc-4fb9-8a70-33338ab9a01d"lineage": "a68d3430-dc71-[PROD_ROOT_DIR_ID]-9991-be16930f9243","lineage": "5b11bdde-a8c2-4a02-93d4-c39232[PROD_ROOT_DIR_ID]77","cli_version": "[CLI_VERSION]+[PROD_ROOT_DIR_ID]44069a29","lineage": "bf681176-596e-43aa-9c1e-7e39a9d6[PROD_ROOT_DIR_ID]","whl": "/Workspace/Users/[USERNAME]/.bundle/my_default_python/dev/artifacts/.internal/my_default_python-0.0.1+179301174[PROD_ROOT_DIR_ID]197650-py3-none-any.whl""whl": "/Workspace/Users/[USERNAME]/.bundle/my_default_python/dev/artifacts/.internal/my_default_python-0.0.1+1792057[PROD_ROOT_DIR_ID]4053359-py3-none-any.whl""last_modified": 17933761[PROD_ROOT_DIR_ID]6,Note that http://127.0.0.1:[PROD_ROOT_DIR_ID]8 is used for initialization.uuid: 33c2e4b1-1077-[PROD_ROOT_DIR_ID]-b7ea-7c2055eae54aTests
go test ./acceptance -run TestAccept/bundle/templates/default-python/classic -updateproduces no golden changes.This pull request and its description were written by Isaac.