Repository navigation
acc: mask run-local ports by context, not as bare numbers - #7325
Merged
Merged
Conversation
The run-local tests registered their random ports with add_repl, which replaces the number anywhere in the output. A port can also occur inside a UUID printed in the same output (node's debugger URL, the X-Request-Id header), turning it into e.g. abcdefab-...-[DEBUG_PORT]0abcdef so [UUID] no longer matches. Mask the ports with regexes anchored on the URL or text around them instead. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
Integration test reportCommit: 5c24d5d
Top 7 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Nov 3, 2026
Collaborator
Integration test reportCommit: cd74e6b
487 interesting tests: 487 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cmd/workspace/apps/run-localandrun-local-nodeallocate random ports and registered them withadd_repl, a literal replacement applied to the whole output. This PR replaces those calls with[[Repls]]regexes anchored on the context where each port appears:http://127.0.0.1:,http://localhost:,ws://127.0.0.1:,"Host": "127.0.0.1:andattach a debugger to port.Why
Literal replacements run before the harness's
[UUID]pattern, and both outputs contain a UUID: node's debugger URLws://127.0.0.1:<port>/<uuid>and theX-Request-Idheader. If the UUID happens to contain the port's digits, it gets cut, e.g.abcdefab-cdef-4abc-8abc-345670abcdefbecomesabcdefab-cdef-4abc-8abc-[DEBUG_PORT]0abcdef, and[UUID]no longer matches. That makes the golden flaky. A second-opinion review flagged this.This is preventive: no dashboard failure of these tests in the last 90 days came from this collision. Their failures there are connection and bind errors, a different problem. Tests: run-local, run-local-node.
Tests
go test ./acceptance -run TestAccept/cmd/workspace/apps/run-local -updatepasses with no golden changes.This pull request and its description were written by Isaac.