Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 27 not selected) 38 tests: regression=36 unreleased=0 coverage=2 failing=0
TestAccept/bundle/resources/catalogs/rename/DMS=: branch ✅ | main (6a8d9bf) ❌ | latest (v1.25.0) ❌main (6a8d9bf): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename/DMS=true: branch ✅ | main (6a8d9bf) ❌ | latest (v1.25.0) ❌main (6a8d9bf): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename_all_out_of_band/DMS=: branch ✅ | main (6a8d9bf) ❌ | latest (v1.25.0) ❌main (6a8d9bf): latest (v1.25.0): 33 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: a44c3dc
Top 37 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/models-rename
branch
from
November 5, 2026 15:30
f364f17 to
18077b3
Compare
denik
force-pushed
the
denik/models-rename
branch
7 times, most recently
from
November 9, 2026 13:09
64af993 to
7496114
Compare
denik
force-pushed
the
denik/models-rename
branch
from
November 9, 2026 14:52
7496114 to
132a53d
Compare
denik
force-pushed
the
denik/models-rename
branch
from
November 9, 2026 14:59
132a53d to
b5f68ef
Compare
denik
force-pushed
the
denik/models-rename
branch
4 times, most recently
from
November 10, 2026 13:23
b0476cd to
36755c1
Compare
Changing a schema's name used to delete and recreate it. It is now an updatable ID field renamed via PATCH new_name, which keeps the schema and everything in it. UC moves the children of a renamed catalog or schema with it. A child volume (or a schema in a renamed catalog) whose catalog_name/schema_name references the parent's name was planned as a recreate, and its create then failed with RESOURCE_ALREADY_EXISTS on every deploy. The planner now re-keys such children (update_id, reason parent_renamed), and they are addressed under their new parents. The test server now moves children on catalog/schema rename and rejects duplicate volume names, matching UC. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
A captured terraform fixture (migrate/command/basic) deploys the same volume name from two targets. The plan goldens already catch a regression to recreate, so the duplicate check is not needed. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Also restores the grants/schemas/change_name golden for the in-place rename, which the rebase onto denik/grants-rekey dropped. Co-authored-by: Isaac <no-reply@databricks.com>
Also restores the grants/schemas/change_name golden for the in-place rename. Co-authored-by: Isaac <no-reply@databricks.com>
schema-rename now renames in place, so it no longer covers the schema recreate. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…nal IDs there An update_id whose changes only follow a parent's rename (or a move the plan found) is marked state_only. For a resource with IDFromState, apply records it under the new ID without calling DoUpdateWithID; it is left out of the textual plan and the applied lines, and counted as unchanged. The internal ID is declared in config as internal_id_field. The framework records it from the remote state on every save, skips its changes in the plan and reads it in findMoved, replacing the InternalID method, the YAML ignore rules and the VolumeId/SchemaId assignments in the adapters. Co-authored-by: Isaac <no-reply@databricks.com>
A schema or catalog renamed with its comment changed sends both in one PATCH and both land. A case-only rename of a schema or volume is accepted by UC, which keeps the lowercase name, so the deploy succeeds and the next plan is a no-op. The test server now lowercases a renamed volume, like UC. Co-authored-by: Isaac <no-reply@databricks.com>
…hain Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…leReason Co-authored-by: Isaac <no-reply@databricks.com>
…ting on main) Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…; record volume_id in empty-resource-id The volume's created_at/updated_at made rename_interrupted flaky ([UNIX_TIME_MILLIS] vs [UNIX_TIME_MILLIS][0] depending on timing). Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Jan N Rose <janniklas.rose@gmail.com>
The recreate deletes the volume at its recorded path after the schema's rename moved it, so the moved volume is left behind. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/models-rename
branch
from
November 10, 2026 14:14
36755c1 to
13aeadd
Compare
A parent renamed in the same plan moves the resource before its recreate runs. The recreate now deletes it at the ID the rename gives it, after the rename. The parent comes from the state's depends_on, since the config may no longer reference it. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/models-rename
branch
from
November 10, 2026 15:28
13aeadd to
a44c3dc
Compare
The plan's state_only re-keys, found IDs and added depends_on must survive serialization. Co-authored-by: Isaac <no-reply@databricks.com>
A registered model's name is now an updatable ID field: a rename sends new_name and keeps the model's versions, instead of deleting and recreating it. A model inside a renamed catalog or schema is re-keyed without a request, like volumes; recreating it failed with RESOURCE_ALREADY_EXISTS. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
After an interrupted parent rename the plan reads the model at its stale ID and has no remote state; sync aliases against the model at its new path instead. Co-authored-by: Isaac <no-reply@databricks.com>
…s with their schema A model missing from its recorded ID is planned as a create again, so DoUpdateWithID always has the plan's remote state. A forced schema or catalog delete in the test server now also deletes the registered models in it, like UC. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…; test rename with a comment change Co-authored-by: Isaac <no-reply@databricks.com>
A config read back from a saved plan force-sends name, so a rename deployed with --plan sent "name": "" next to new_name, which UC rejects. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/models-rename
branch
from
November 10, 2026 16:06
a44c3dc to
43d07f6
Compare
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 11, 2026
…names (databricks#7408) ## Changes Make the test server behave like Unity Catalog where the UC rename PRs depend on it: - A renamed catalog moves its schemas, volumes, registered models and secrets. A renamed schema moves its volumes, registered models and secrets. - A forced catalog or schema delete also deletes what is in it. - Creating a catalog under a taken name fails with `CATALOG_ALREADY_EXISTS`. - A renamed schema or volume gets a lowercased name. A renamed registered model updates its `full_name` and keeps its versions, and setting `name` and `new_name` in one update is rejected. The `schema-catalog-change` and `registered-model-catalog-change` migrate scripts created a catalog that their captured replay creates again; the fake now rejects that, so the scripts no longer create it. ## Tests New `acceptance/cmd/workspace/uc-renames` (Cloud = true) checks each behavior with plain CLI calls. It passes locally and on AWS, GCP and Azure. Next: databricks#7343 (schema rename) stacks on this PR, followed by databricks#7379 and databricks#7381. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changing a registered model's
namenow renames it in place (PATCH new_name) instead of deleting and recreating it, so the model keeps its versions. The recreate only matched Terraform, which is gone.A model in a renamed catalog or schema (
schema_name: ${resources.schemas.<s>.name}) now follows its parent the way volumes do in #7343: withIDFromState, the framework re-keys it without a request (state_only). It used to be planned as a recreate whose create failed withRESOURCE_ALREADY_EXISTS(verified on AWS), and every later deploy tried to create it again.UC rejects an update that sets both
nameandnew_name, so a rename leavesnameout (#7408 makes the test server reject it too).Stacked on #7343. UC secrets get the same fix in #7381.
Tests
registered_models/rename(Cloud = true): rename the model, then its schema, then its catalog, then the model again together with its comment (one PATCH).created_atstays the same and the final plan is a no-op.registered_models/basic(Cloud = true, AWS) andmigrate/auto/registered-model-rename: a name change now renames.This pull request and its description were written by Isaac.