Repository navigation
Replace lakeflow-integrations template examples with integration catalog - #7443
Merged
Merged
Conversation
Replaces the template's examples with five ready-to-use integrations from the Lakeflow integration catalog, so generated projects (and assistants working in them) follow current best practices: send_slack_message, wait_for_slack_reaction, create_jira_issue, call_rest_api, and wait_for_rest_api. The old slack.py and wait_for_run_sensor.py examples and the jobs that ran them are removed. The new examples use HttpUcConnectionParameter, ParameterMetadata, and PollResult, which need databricks-lakeflow-integrations 0.0.6, so the template's pin moves to >=0.0.6,<0.1 and the vendored wheel is bumped to 0.0.6. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/bundle/templates/lakeflow-integrations/DMS=: branch ✅ | main (54b9981) ❌ | latest (v1.25.0) ❌main (54b9981): latest (v1.25.0): |
Collaborator
✅ Integration test reportCommit: bd3c03d
|
No example imports requests anymore, and the acceptance test no longer provides a stub for it, so uv failed to resolve it offline on CI. Co-authored-by: Isaac <no-reply@databricks.com>
afberg
reviewed
Nov 11, 2026
| 2. Click the **deployments rocket** 🚀 in the left sidebar to open the | ||
| **Deployments** panel, then click **Deploy**. | ||
| 3. To run a deployed job, hover over the resource in the **Deployments** panel | ||
| 3. After you add a job under `resources/` and deploy it, run it: hover over the resource in the **Deployments** panel |
Contributor
There was a problem hiding this comment.
This sentence reads a little gibberish-y? Can we say "to run it", "run it by" or "you can run it by" etc?
Contributor
Author
There was a problem hiding this comment.
Rather than running it in a job, instead I added instructions on how to add the integrations to the task palette. I think that makes more sense.
Updated README to include instructions for adding integrations to the task palette.
Updated instructions for deploying integrations and added configuration example for task palette.
pietern
approved these changes
Nov 11, 2026
pietern
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock merge.
Collaborator
❌ Integration test reportCommit: 7ba9e57
6 interesting tests: 4 FAIL, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds ready-to-use integrations that we offer in the UI as examples in the DABs template. The goal is that the primary way to author custom integrations for the user is through Genie. Genie tends to follow the practices used in the examples of the DABs template. In order to have Genie follow best practices and use latest features of
databricks-lakeflow-integrations, we put the ready-to-use integrations in here. Then Genie has a pattern to follow.Tests
TestAccept/bundle/templates/lakeflow-integrationspasses. Duringbundle deploy, the generator discovers and emits YAML for all five examples against the vendored 0.0.6 wheel.This pull request and its description were written by Isaac.