Repository navigation
acc: drop no-op rm in apps/missing-service-principal - #7545
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=2 coverage=0 failing=0
TestAccept/bundle/resources/apps/missing-service-principal/DMS=: branch ✅ | main (4668f26) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/resources/apps/missing-service-principal/DMS=true: branch ✅ | main (4668f26) ✅ | latest (v1.26.0) ❌latest (v1.26.0): |
Collaborator
✅ Integration test reportCommit: 7c5b8a3
Top 11 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 12, 2026 16:32
denik
enabled auto-merge
November 12, 2026 16:32
andrewnester
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #7533, addressing review feedback: remove
rm -f out.requests.txtfrom thebundle/resources/apps/missing-service-principalscript. The harness records requests to$OUT_REQUESTSin a separate output dir, so the line did nothing. The golden output is unchanged: the firstprint_requests.pyalready listed the create request.The hint text from #7533 stays as is ("wait for the deletion to finish"). Right after
databricks apps delete, the app is still returned in DELETING, andbundle planplans an update, not a create.IsGoneis only checked for resources being deleted. So a redeploy run before the deletion finishes does not recreate the app. Details are in the review thread on #7533.Tests
go test ./acceptance -run TestAccept/bundle/resources/apps/missing-service-principalpasses locally with no output change.Written by an AI agent (harness_auto, opus5.5, isaac_claude).
This pull request and its description were written by Isaac.