Repository navigation
air: Include run details in air get JSON - #7624
Merged
Merged
Conversation
Jobs runs/get leaves max_retries out of every task run, and the SDK decodes the missing field as 0, so `air get` and the `air list` info pane showed "Max Retries 0" even for runs submitted with the default of 3 or an explicit limit . The server value is now used only when the response carries the key. For a one-time submit run, the limit is read from the run's uploaded training config: the configured value when it sets max_retries, and "3 (CLI default)" for ai_runtime_task runs that leave it unset, since the CLI always submits its default. Job runs, multi-container runs, legacy gen_ai_compute_task runs with no explicit value, and runs whose config can't be read show N/A. The derivation is resolveMaxRetries, which returns the limit and its source so `air get -o json` can expose the same value later. Co-authored-by: Isaac <no-reply@databricks.com>
Expose typed accelerator, environment, retry, user, MLflow and sweep details without changing existing JSON fields. Read and emit the stored config only when --include-config is passed, because it may contain plaintext environment variables and parameters. Without it, config-derived retry limits remain unknown. Bound config downloads before SDK response buffering and omit oversized files in text and JSON. Guarantee an empty array for sweep tasks when iteration lookup fails. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 5 changed tests (limit=20, 0 not selected) 5 tests: regression=5 unreleased=0 coverage=0 failing=0
TestAccept/air/get: branch ✅ | main (ce48e57) ❌ | latest (v1.26.0) ❌main (ce48e57): latest (v1.26.0): TestAccept/air/get-ai-runtime: branch ✅ | main (ce48e57) ❌ | latest (v1.26.0) ❌main (ce48e57): latest (v1.26.0): TestAccept/air/get-mlflow-retry: branch ✅ | main (ce48e57) ❌ | latest (v1.26.0) ❌main (ce48e57): latest (v1.26.0): TestAccept/air/get-pending: branch ✅ | main (ce48e57) ❌ | latest (v1.26.0) ❌main (ce48e57): latest (v1.26.0): TestAccept/air/help: branch ✅ | main (ce48e57) ❌ | latest (v1.26.0) ❌main (ce48e57): latest (v1.26.0): |
Collaborator
✅ Integration test reportCommit: 7528690
Top 11 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…etails Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…etails Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…etails Co-authored-by: Isaac <no-reply@databricks.com>
The config downloaded for the JSON output is reported verbatim, so a config uploaded from a Windows checkout (CRLF) produced different JSON than the same config uploaded from Unix (LF). Normalize the line endings for the machine-readable field; the text display already reformats the config. Co-authored-by: Isaac <no-reply@databricks.com>
vinchenzo-db
approved these changes
Nov 16, 2026
vinchenzo-db
left a comment
Contributor
There was a problem hiding this comment.
overall lgtm, but consider if we want to enable InsecureSkipVerify
| transport := cfg.Transport | ||
| if transport == nil { | ||
| transport = http.DefaultTransport | ||
| } |
Contributor
There was a problem hiding this comment.
Codex flags that we don't cover the InsecureSkipVerify case;
so it should be:
if cfg.Transport != nil {
return cfg.Transport
}
if cfg.InsecureSkipVerify {
// Create a transport with certificate verification disabled.
}
# Conflicts: # cmd/air/list_detail_test.go
The fixture's fake run has no max_retries on its task, which the Jobs API leaves out, so the reported limit is now N/A instead of 0. Co-authored-by: Isaac <no-reply@databricks.com>
…etails # Conflicts: # acceptance/air/help/output.txt # cmd/air/list_detail_test.go
artemy-kolesnikov
enabled auto-merge
November 16, 2026 22:15
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
❌ Integration test reportCommit: 479098f
34 interesting tests: 18 FAIL, 7 RECOVERED, 5 flaky, 4 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add typed run details to
air get -o json, including flat accelerator fields, environment, user, MLflow run name, retry-limit provenance and sweep details.--include-configopts into the stored config and its source. Downloaded configs larger than 1 MiB are omitted.Why
The text view exposes run details that machine-readable output omits, forcing consumers to parse the text display. Config is opt-in because it can contain plaintext environment variables and parameters. Without the flag, JSON does not read the config, so a retry limit that is not reported by the run is
nulleven when text can derive it from the stored config. This change depends on the retry-limit patch in #7623.Tests
tasksas an empty array.This pull request and its description were written by Isaac.