Repository navigation
ci: enable Opus 5.5 with the upgraded bot engine - #512
Merged
Merged
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
changed the title
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
marked this pull request as draft
October 22, 2026 03:35
vuanhphung
changed the title
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Nit
Looks good, with no blocking issues. All six workflows use the same model, set both through the *_BOT_MODEL_OVERRIDE variables and the MODEL_ENDPOINT URLs, and no opus-4-8 references are left. The engine SHA, SDK/CLI versions and Node version are each set in exactly one place and every bot inherits them. Merge this only after databricks-bot-engine#166 lands, because the new SHA has to exist on the engine repo.
Other findings
- ⚪ Nit — The new comment in
install-bot-engine/action.yml(around L136) replaces the older explanation of why REF mode installs the engine's dependencies unpinned and pins the SDK/CLI by version: a consumer can't see the engine's hash-locked requirements. That reasoning is still accurate and worth keeping. Consider keeping it next to the new note about the bundled binary.
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Contributor
|
You probably need to update the sha |
vuanhphung
marked this pull request as ready for review
October 22, 2026 17:49
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
Allow maintainers with write access to invoke the engineer bot with a top-level `@bot` comment on an open, same-repository PR. Review requests inspect the diff without edits; change requests can push fixes and reply. Mention and follow-up writers share a queue of up to 100 pending requests. Eligibility is rechecked before PR checkout. Prompts and cache warming use the trusted default branch; PR diffs are separate read-only reference files, with the base refreshed after queueing and the checked-out head SHA included in replies. The trigger activates once the workflow lands on `main`. This PR includes merged #512: all six bot workflows use `databricks-claude-opus-5-5`, with engine commit `ac3b08eab993ef14bf997a9bf4c776fa5acb16d8` from databricks/databricks-bot-engine#166. SDK/CLI defaults are `0.2.167` / `2.1.300`, with Node 22 for the npm CLI. The engine adds `[1m]` automatically. Validation: 39 local workflow scenarios and shell checks passed, including permission lookup failures, closed/merged PRs, and head changes after queueing. actionlint 1.7.12 passed with a temporary compatibility filter for the new `queue` key; `queue: max` was verified against GitHub's current syntax documentation. Diff checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure all six bot workflows to use
databricks-claude-opus-5-5through the supported per-bot overrides. Pin the shared engine upgrade and align the local SDK/CLI defaults to0.2.167/2.1.300, with Node 22 for the npm CLI. The engine adds the[1m]suffix automatically.Pins merged databricks/databricks-bot-engine#166 (
ac3b08eab993ef14bf997a9bf4c776fa5acb16d8). This PR is also stacked on #511.Validation: all six workflow callers, action YAML/shell syntax, and engine/SDK/CLI/Node pin consistency passed. The engine upgrade passed CI, including the JFrog SDK install and bundled CLI version check, plus 1,095 local tests (14 skipped).