Repository navigation
fix(kernel): honor the client CloudFetch default - #574
Open
aakash-saravanan-db wants to merge 3 commits into
Open
aakash-saravanan-db wants to merge 3 commits into
aakash-saravanan-db wants to merge 3 commits into
Conversation
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
aakash-saravanan-db
temporarily deployed
to
azure-prod
November 11, 2026 00:03 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
aakash-saravanan-db
had a problem deploying
to
azure-prod
November 11, 2026 00:03 — with
GitHub Actions
Failure
GitHub Actions
Failure
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Nit
Looks good. The change is small and contained: the caller's configuration is copied rather than mutated, the key is removed regardless of case before being set, and queryTags still merges correctly after it, all backed by parameterized unit tests. I couldn't confirm from this repo that the kernel actually acts on the can_cloud_download session-conf key (nothing in native/ mentions it), so that rests on the PR's proxy-based validation.
Other findings
- ⚪ Nit — CHANGELOG: the new entry is followed by a blank line, so it sits apart from the rest of the
Unreleasedlist, and unlike its neighbours it has no PR reference (e.g.(#574)).
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
aakash-saravanan-db
temporarily deployed
to
azure-prod
November 11, 2026 00:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aakash-saravanan-db
had a problem deploying
to
azure-prod
November 11, 2026 00:08 — with
GitHub Actions
Failure
GitHub Actions
Failure
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel backend ignores the DBSQLClient useCloudFetch default, so applications still download results from cloud storage when they disable it. Forward useCloudFetch: false when opening a session, preserving caller configuration and giving the disable option precedence over differently cased capability keys. Per-statement overrides remain unsupported on the kernel backend.
Validation: build, lint, type check, Prettier, and 1,510 unit tests passed. A real driver loaded the locally built dist and fetched all 250,000 rows with 32,000,000 payload bytes and the expected data hash. A proxy observed zero storage downloads when disabled and two when enabled. Matched Thrift comparisons, error recovery, reuse, and close passed for connection configuration.