[vuanhphung]

What type of PR is this?

• Other — CI and bot guidance

Description

Port the shared engineer/reviewer bot lessons from databricks/databricks-sql-nodejs#571 and #572: keep changes within maintainer scope, ground findings in evidence, select unit or live tests by behavior, and handle stale reviews. Follow-ups load trusted default-branch config; agents cannot edit their own .bot/ settings.

Sync conflicting bot PRs only when CHANGELOG.md changes are additive # Unreleased entries. Other conflicts receive a maintainer comment. Sync is limited to PRs targeting the default branch.

How is this tested?

• Unit tests

Passed 18 local changelog/branch-sync cases, YAML parsing, shell syntax checks, and git diff --check. Added a CI workflow to run the sync tests.

Related Tickets & Documents

databricks/databricks-sql-nodejs#571
databricks/databricks-sql-nodejs#572

---

This PR was created with GitHub MCP.

[peco-review-bot]

Verdict: 1 Low

Looks good. I found one low-severity issue: gh pr list --limit 100 can silently skip bot PRs past the first 100. The sync script handles this repo's # X.Y.Z (date) changelog headings correctly, and the trusted-config and fork gating hold up. Not verified: the engine's --bot flag isn't visible from this repo. Nit: the comment near engineer-bot.yml's live-warehouse env still says the flow always reproduces the bug through tests/e2e, which no longer matches the new choice between unit and e2e tests.

[peco-review-bot]

Verdict: 1 Low

Looks good overall, with one low concern: the new sync job can race with a follow-up run that is already in progress on the same PR. The changelog-merge logic and its tests reject everything except additive Unreleased entries. Main-branch config is extracted with git archive, which keeps the agent from editing its own config. I couldn't check whether the pinned engine supports the new --bot flag because no engine context repo is available. Nit: two lines in sync-engineer-bot-prs.py (the SECTION regex and the gh pr list call) go past the 100-char limit in CONTRIBUTING.md. Also, --limit 100 will silently skip any PRs beyond 100.