Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
No new issue is required. This PR extends GPU regression coverage for existing NAO integration cases.
Related PRs:
02_NAO_Gammaand03_NAO_multiksuites.The changes build on these previously merged contributions without modifying their implementation.
Unit Tests and/or Case Tests for my changes
Local GPU validation environment
Commands run
The existing
02_NAO_Gammaand03_NAO_multikGPU regression suites were executed separately in an isolated validation directory using:Here,
BINpoints to the previously validated CUDA/LibXC-enabled ABACUS executable. All registered test INPUT files in the validation directory were configured withdevice gpu.Result summary
02_NAO_Gamma03_NAO_multikAll four newly registered cases passed:
02_NAO_Gamma/scf_metagga03_NAO_multik/scf_out_chg_tau03_NAO_multik/scf_nspin4_nsoc_hr03_NAO_multik/scf_nspin4_soc_hrThe final
test.sumfiles were checked to confirm that all 97 registered cases had successful results, including all four new entries.Checks not run, with reason
What's changed?
This PR extends CUDA regression coverage for four existing numerical atomic orbital (NAO) integration cases.
1. Register existing NAO cases for GPU regression
Add
scf_metaggato:tests/02_NAO_Gamma/CASES_GPU.txtAdd the following cases to:
tests/03_NAO_multik/CASES_GPU.txtscf_out_chg_tauscf_nspin4_nsoc_hrscf_nspin4_soc_hrThese additions cover SCAN/meta-GGA calculations, charge/kinetic-energy-density output, and noncollinear Hamiltonian output with and without spin-orbit coupling.
2. Enable LibXC in the CUDA workflow
Add
-DENABLE_LIBXC=ONto the CMake configuration in.github/workflows/cuda.yml.This is required for running the SCAN/meta-GGA regression cases in the CUDA workflow, since LibXC is disabled by default in the ABACUS CMake configuration.
3. Reuse the existing GPU test infrastructure
The CUDA workflow already prepares NAO test INPUT files with
device gpuand invokesAutotest.shusingCASES_GPU.txt. No additional workflow jobs or test directories are introduced.4. Preserve existing reference data
No test INPUT files, physical parameters, numerical reference values, or property comparison tools are modified by this PR.
Governance Notes
INPUT/docs changes
device gpufor the registered test cases.Core module impact
source/.Exceptions requested
None.
Expected outcome
The existing CUDA CI workflow will continuously check the four additional NAO regression cases, helping detect future regressions in LibXC/meta-GGA support and noncollinear Gint Hamiltonian assembly on GPU.
The GitHub-hosted CUDA workflow result remains subject to PR CI verification.