Repository navigation
Read Junior as a given name too, and lean a generation word by case only where its reading says so (#1039) - #1052
Merged
Merged
Conversation
…nly where its reading says so (#1039) junior and júnior gain given and family readings, so the words-to-spare count gates them (rules/S11): 'Silva, Junior Carlos' reads given 'Junior', where 2.4.0 through 2.8.1 read suffix 'Junior Carlos'. S6's Title-case lean for a gated suffix word becomes a property, title_case_is_name, carried by the readings it was true of (fils, the Slavic st., kc, pc, dl); without it a gated word's writing says nothing, so 'John Smith Junior' keeps the suffix. Adding the property moved no parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…/S11, record what moved The 2.x translation gives a gated non-agnomen word title_case_is_name, the lean 2.x gave it. rules/S5 and S11's precedence named every generation word's Title case; S7 and S11 now say a suffix word that is also a name counts as a name word in front of another. The decisions entry separates the undecided consequences, lists the re-spelled decided examples, the bracketed and dotted Junior, and corrects the FEC count. AGENTS.md, the RFC table and customize.rst name the property. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rate.rst's 2.x spelling, FEC count Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng leans only by title_case_is_name (#1039) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1039.
What changes
junior(mul.toml) andjúnior(pt.toml) gaingivenandfamilyreadings. They become suffix words that are also names, so the words-to-spare count gates them (rules/S11).A new reading property:
title_case_is_name.fils, which French writes in lower case as the generation;st.;kc,pcanddl(Should common British post-nominals (KC,FREng,DL,FRS,PC…) be in the vocabulary, soJane Doe KCkeeps familyDoe? #965);père, which Locale packs forAlexandre Dumas filsandJiří Dienstbier ml.: generational words that collide outside their language #684 turned on by default while this PR was open, gated asfilsis. Without the property it would have lost Locale packs forAlexandre Dumas filsandJiří Dienstbier ml.: generational words that collide outside their language #684's lean (Jean Olivier Père→ suffix 'Père'), so it carries it and reads as on master.Junioris written in Title case for the generation too, so it doesn't carry the property, andJohn Smith Juniorkeeps the suffix.junior's readings went in, and a 7,200-parse grid over every gated word under three orders and the cs/pt packs moved nothing.Lexicon.add(w, kind="generation", title_case_is_name=True). The build allows it on a generation reading or on a credential written as a word.Lexiconholding a non-agnomen word insuffix_words_ambiguoustranslates to a reading with the property, the lean 2.x gave it. The refusal message and the migrate.rst row say so.What moves
Measured with
tools/differential/measure.py --baseagainst master 39839b9. The committed snapshot moves only the rules' and case table's Junior names. The CLDR, GND and Wikidata records don't move.suffix-or-namereport aloneADELSON JUNIOR→ family 'JUNIOR'Fabio Junior→ family 'Junior'Mr Oliver Junior→ family 'Junior';(Junior)→ nickname, as(Neto)… SILVA JUNIOR, DOCTORATE→ family '… JUNIOR' (base already reversed)BRITO JUNIOR, RAIMUNDO→ family 'BRITO JUNIOR'The other six local corpora don't move.
Agreement with the filed boxes:
Decided, and accepted without a decision yet
Reading.kindstays 'generation'; and make the lean a property that marks the words whose case leans, so the default is no lean.Netoalready is on master (Pedro Neto Filho→ family 'Neto').Pedro Junior Filhoreads family 'Junior', suffix 'Filho', where 1.4.0 through 2.8.1 read middle 'Junior', family 'Filho'. LikewisePedro Junior fils.Jnr, which has no name reading, so they keep testing it.Smith, Junior.now reads title 'Junior.' by rules/H2's period shape, asSmith, Neto.does. 2.2.0 through 2.8.1 read the suffix. No corpus name writes it.Docs
Review
juniororjúniorname. It found the 2.x translation dropping the lean (fixed), S5 left stale (fixed), andSmith, Junior.(recorded).🤖 Generated with Claude Code