Repository navigation
Remove three Wikipedia footnote marks from SUFFIX_ACRONYMS - #736
Merged
Merged
Conversation
cva[22], gaee[14] and np[18] arrived with the af5bdab bulk import, the bracketed number being the source page's reference mark. They matched only a token written with the mark, so "John Smith NP[18]" read suffix NP[18]; np and cva keep their clean entries, and gaee never had one. The snapshot does not move. Recorded in decisions/suffix-acronym-collisions with a recompute line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 46 46
Lines 4589 4589
=======================================
Hits 4545 4545
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cva[22],gaee[14]andnp[18]came intoSUFFIX_ACRONYMSwith the 2019 bulk import from Wikipedia (af5bdab). The bracketed number is the source page's footnote mark, copied along with the acronym. The migration spike for the 3.0 vocabulary spec found them. Removing them now means the TOML files never have to carry them.What moves: only a token written with the footnote mark itself.
John Smith NP[18]read suffixNP[18]and now reads familyNP[18].npandcvaalready have clean entries, soJohn Smith NPandJohn Smith CVAstill read as suffixes.gaeenever had a clean entry.John Smith GAEEreads familyGAEEbefore and after. Whether to add a cleangaeeis a separate vetting question and is not part of this PR.Checks:
tools/differential/snapshot.py: matches the snapshot.cldr_agreement.py: matches its records.uv run pytest: 21465 passed, 123 skipped, 3 xfailed.No release-log bullet: no real name reads differently.
🤖 Generated with Claude Code