Skip to content

Remove three Wikipedia footnote marks from SUFFIX_ACRONYMS - #736

Merged
derek73 merged 1 commit into
masterfrom
fix/footnote-marker-acronyms
Oct 19, 2026
Merged

derek73 merged 1 commit into
masterfrom
fix/footnote-marker-acronyms

Conversation

@derek73

@derek73 derek73 commented Oct 19, 2026

Copy link
Copy Markdown
Owner

cva[22], gaee[14] and np[18] came into SUFFIX_ACRONYMS with the 2019 bulk import from Wikipedia (af5bdab). The bracketed number is the source page's footnote mark, copied along with the acronym. The migration spike for the 3.0 vocabulary spec found them. Removing them now means the TOML files never have to carry them.

What moves: only a token written with the footnote mark itself. John Smith NP[18] read suffix NP[18] and now reads family NP[18].

  • np and cva already have clean entries, so John Smith NP and John Smith CVA still read as suffixes.
  • gaee never had a clean entry. John Smith GAEE reads family GAEE before and after. Whether to add a clean gaee is a separate vetting question and is not part of this PR.

Checks:

  • tools/differential/snapshot.py: matches the snapshot.
  • cldr_agreement.py: matches its records.
  • uv run pytest: 21465 passed, 123 skipped, 3 xfailed.
  • ruff and mypy: clean.
  • No other vocabulary entry contains a bracket. The recompute line is in the new bullet in decisions/suffix-acronym-collisions, which also says where the entries came from, so a future bulk import is checked for brackets.

No release-log bullet: no real name reads differently.

🤖 Generated with Claude Code

cva[22], gaee[14] and np[18] arrived with the af5bdab bulk import, the
bracketed number being the source page's reference mark. They matched
only a token written with the mark, so "John Smith NP[18]" read suffix
NP[18]; np and cva keep their clean entries, and gaee never had one.
The snapshot does not move. Recorded in
decisions/suffix-acronym-collisions with a recompute line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added the bug label Oct 19, 2026
@derek73 derek73 self-assigned this Oct 19, 2026
@derek73 derek73 added this to the 2.5 milestone Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (65093cf) to head (ca0842d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          46       46           
  Lines        4589     4589           
=======================================
  Hits         4545     4545           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit 6803a26 into master Oct 19, 2026
12 checks passed
@derek73
derek73 deleted the fix/footnote-marker-acronyms branch October 19, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant