Skip to content

Ask is_title_piece in C5's speaker scan and pair_only - #739

Merged
derek73 merged 2 commits into
masterfrom
fix/comma-title-copies
Oct 19, 2026
Merged

derek73 merged 2 commits into
masterfrom
fix/comma-title-copies

Conversation

@derek73

@derek73 derek73 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Follow-up to #738. _comma.decide had two more hand copies of the one-word vocab:title test that #738 replaced in C12 (a suffix word ending the name before the comma). A title joined by P3 (Mr. and Mrs.) doesn't pass that test. Both sites now ask is_title_piece:

  • C5's speaker scan: the unambiguous suffix word "not also title vocabulary" that makes paired initials the credential run.
  • pair_only: "only titles" in front of the first pair. This is the C11 report's paired-initials exception.

Default vocabulary: no reading moves. The two tests differ only on a joined title, and both sites sit behind C4's run test: the speaker scan runs only when the part is the credential run, and the report asks pair_only only alongside it. A joined title's free connective fails C4's every-word-a-suffix-word test, so by default neither site ever meets one. (A connective that is suffix vocabulary gets frozen rather than joined.)

  • Measured (2026-10-19) against the parent 550720c, extracted with git archive and __file__ asserted on both sides: 7 names before the comma × 15 lead-ins × 11 tails × 3 orders = 3,465 parses, with 0 moves in readings, ambiguity details or initials(). The grid is in decisions/C5.
  • Wider grids: the reviews ran about 200,000 more default-vocabulary parses each, covering more heads, lead-ins and the comma policies. No moves.

One configured move, accepted. The code review found it. With a custom connective that a configured delimiter splits into suffix words, Lexicon.default().add(conjunctions={'phd/md'}) plus Policy(extra_suffix_delimiters=frozenset({'/'})), the joined title passes C4's run test:

Input Before After
John Smith, Ms. PHD/MD Ph. D. GJ given John, family Smith, suffix Ms. PHD/MD Ph. D. GJ title Ms. PHD/MD Ph. D., given GJ, family John Smith
John Smith, MD PHD/MD Ms. G.J. K.L. same fields, no report same fields, plus SUFFIX_OR_NAME

This is the direction #738 took: a joined title reads as a lone title word does. It's recorded as accepted in decisions/C5, and decisions/C11 points to the entry.

Frames: at most +3, only on parts holding paired initials. Smith, John and the reference row are unchanged.

No rule text or snapshot changes. Suite: 21,589 passed; mypy and ruff clean.

🤖 Generated with Claude Code

Both hand-copied the one-word `vocab:title` test that PR #738 found
reading a joined title ('Mr. and Mrs.') as a credential in C12. Here
the swap moves no reading: 0 of 3,465 measured parses (readings,
ambiguity details, initials) move. The speaker test never disagrees
with the copy on the grid, since a joined title holding a suffix fails
C4's every-word test first; pair_only disagrees on 6 inputs, all behind
a generation, where C12's report is chosen first. The swap is for
drift. Recorded in decisions/C5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 self-assigned this Oct 19, 2026
@derek73 derek73 added this to the 2.5 milestone Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (550720c) to head (9e90a90).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          46       46           
  Lines        4647     4647           
=======================================
  Hits         4603     4603           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- decisions/C5: both sites sit behind C4's run, which a joined title's
  free connective fails, so the default vocabulary cannot move; the
  G.J. A.B. clause corrected
- decisions/C5: a configured connective split into suffix words by a
  configured delimiter passes the run, and there two readings move
  (found by the code review); accepted
- decisions/C11: pointer for pair_only, the report's exception

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 changed the title Ask is_title_piece in C5's speaker scan and pair_only (no reading moves) Ask is_title_piece in C5's speaker scan and pair_only Oct 19, 2026
@derek73
derek73 merged commit 84a3b2b into master Oct 19, 2026
12 checks passed
@derek73
derek73 deleted the fix/comma-title-copies branch October 19, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant