Repository navigation
Ask is_title_piece in C5's speaker scan and pair_only - #739
Merged
Merged
Conversation
Both hand-copied the one-word `vocab:title` test that PR #738 found reading a joined title ('Mr. and Mrs.') as a credential in C12. Here the swap moves no reading: 0 of 3,465 measured parses (readings, ambiguity details, initials) move. The speaker test never disagrees with the copy on the grid, since a joined title holding a suffix fails C4's every-word test first; pair_only disagrees on 6 inputs, all behind a generation, where C12's report is chosen first. The swap is for drift. Recorded in decisions/C5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 46 46
Lines 4647 4647
=======================================
Hits 4603 4603
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- decisions/C5: both sites sit behind C4's run, which a joined title's free connective fails, so the default vocabulary cannot move; the G.J. A.B. clause corrected - decisions/C5: a configured connective split into suffix words by a configured delimiter passes the run, and there two readings move (found by the code review); accepted - decisions/C11: pointer for pair_only, the report's exception Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #738.
_comma.decidehad two more hand copies of the one-wordvocab:titletest that #738 replaced in C12 (a suffix word ending the name before the comma). A title joined by P3 (Mr. and Mrs.) doesn't pass that test. Both sites now askis_title_piece:pair_only: "only titles" in front of the first pair. This is the C11 report's paired-initials exception.Default vocabulary: no reading moves. The two tests differ only on a joined title, and both sites sit behind C4's run test: the speaker scan runs only when the part is the credential run, and the report asks
pair_onlyonly alongside it. A joined title's free connective fails C4's every-word-a-suffix-word test, so by default neither site ever meets one. (A connective that is suffix vocabulary gets frozen rather than joined.)git archiveand__file__asserted on both sides: 7 names before the comma × 15 lead-ins × 11 tails × 3 orders = 3,465 parses, with 0 moves in readings, ambiguity details orinitials(). The grid is in decisions/C5.One configured move, accepted. The code review found it. With a custom connective that a configured delimiter splits into suffix words,
Lexicon.default().add(conjunctions={'phd/md'})plusPolicy(extra_suffix_delimiters=frozenset({'/'})), the joined title passes C4's run test:John Smith, Ms. PHD/MD Ph. D. GJJohn, familySmith, suffixMs. PHD/MD Ph. D. GJMs. PHD/MD Ph. D., givenGJ, familyJohn SmithJohn Smith, MD PHD/MD Ms. G.J. K.L.This is the direction #738 took: a joined title reads as a lone title word does. It's recorded as accepted in decisions/C5, and decisions/C11 points to the entry.
Frames: at most +3, only on parts holding paired initials.
Smith, Johnand the reference row are unchanged.No rule text or snapshot changes. Suite: 21,589 passed; mypy and ruff clean.
🤖 Generated with Claude Code