Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2954 +/- ##
==========================================
- Coverage 84.50% 84.48% -0.03%
==========================================
Files 260 260
Lines 58509 58529 +20
Branches 4962 4964 +2
==========================================
+ Hits 49443 49447 +4
- Misses 8238 8250 +12
- Partials 828 832 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| def __str__(self): | ||
| if self._subdomain is not None: | ||
| return (f"{self.__class__.__name__}({self.lhs}, {self.rhs}," |
Contributor
There was a problem hiding this comment.
nitpicking, this part of the fstring is identical to the one you return if no subdomain is present...
| expressions = cls._sanitize_exprs(expressions, **kwargs) | ||
|
|
||
| # Hook for retrieval of preexisting operators | ||
| # TODO: should this emit timing info if an operator is retrieved |
Contributor
There was a problem hiding this comment.
only in the hook, I'd say? so I guess you can drop this TODO comment...
EdCaunt
force-pushed
the
operator-lookup-hook
branch
from
June 29, 2026 14:27
afa93a8 to
86d0d36
Compare
EdCaunt
force-pushed
the
operator-lookup-hook
branch
from
November 6, 2026 11:50
6bdc180 to
4e17810
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.