Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
- Coverage 84.51% 84.45% -0.07%
==========================================
Files 260 260
Lines 58493 58569 +76
Branches 4962 4968 +6
==========================================
+ Hits 49438 49466 +28
- Misses 8226 8270 +44
- Partials 829 833 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| subdomain = Region(grid=serial) | ||
|
|
||
| def functions(grid): | ||
| kwargs = {'grid': grid, 'space_order': 4, 'dtype': np.float64} |
There was a problem hiding this comment.
Seems to have copied a pattern from test_dimension.py. Apparently you introduced that pattern 😂
There was a problem hiding this comment.
Seems to do nothing, so removing it throughout the codebase
| """ | ||
| kwargs = {'dtype': np.int32, 'is_const': True, 'nonnegative': True, | ||
| 'root': self.root} | ||
| lofs = RankOffset(name=f"{self.root.name}_lofs", side=LEFT, **kwargs) |
There was a problem hiding this comment.
Likely should be a (cached) property of self.root to avoid duplication, ...
| rank's local indices. Unlike `_interval`, these are not clipped to this | ||
| rank, so with domain decomposition they may lie in the halo or beyond. | ||
| """ | ||
| kwargs = {'dtype': np.int32, 'is_const': True, 'nonnegative': True, |
There was a problem hiding this comment.
Just make an __init__ for RankOffset
There was a problem hiding this comment.
This was a pattern copied from where Thickness gets created, but turns out it's mostly unnecessary, so removing everywhere.
| def _arg_values(self, grid=None, **kwargs): | ||
| root = self.root | ||
| if grid is not None: | ||
| root = next((d for d in grid.dimensions if d.name == root.name), root) |
There was a problem hiding this comment.
Lifted directly from Thickness as far as I can tell. Git blame says @FabioLuporini did it - any idea why?
| if grid is not None: | ||
| root = next((d for d in grid.dimensions if d.name == root.name), root) | ||
|
|
||
| if grid is None or not grid.is_distributed(root): |
There was a problem hiding this comment.
is_distributed is always true for all grid dimensions so i think you're looking for is_decomposed
There was a problem hiding this comment.
This is essentially just guarding the subsequent if block, ensuring that grid.distributor.decomposition[root] won't throw an error
8435a25 to
7249fa0
Compare
|
Need rebase and gtg |
Makes the indicator for a subdomain use the global bounds rather than the local one