Repository navigation
Correct stale comments left by numbered ids and the image editor, and drop a dead Workspace id retry - #1164
Merged
Conversation
…e audit disclosure split Also drop workspace-store's freshWorkspaceId, whose retry loop the id pool's own in-use check already makes unreachable, and make a Pocket install-notice test assert against null, which installNotice returns.
Deploying mouseterm with
|
| Latest commit: |
0e4eae9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://490b889c.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-stale-comments-2026.mouseterm.pages.dev |
dormouse-bot
requested a deployment
to
hosted-preview
October 17, 2026 10:57 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments, one spec table cell, two rationale/spec sentences, and test type annotations still described behavior that recent merges changed. One dead helper goes with them. Nothing here changes runtime behavior; CI's typecheck and test suites are the verification.
Left by numbered Surface/Workspace ids (#1085)
standalone/src-tauri/src/lib.rs: the registry field said Workspaces sit "under their stable refs" (refs are gone), andClosedWindowsaid its snapshot was built "with fresh ids", thoughwindowReopenSnapshotnow keeps the closed window's ids markedreopened(aspush_closed_window's own doc already says).lib/src/lib/workspace-store.ts:freshWorkspaceIdretriedgenerateWorkspaceId()until no Workspace held the id, but the id pool'smintalready loops oninUse: hasWorkspace— the same test — so the retry could never run. Callers now callgenerateWorkspaceId()directly.use-dor-control.ts/use-tool-run-end.tscomments, and test response types inreopen.test.tsxandWorkspaceWindow.test.tsx, still namedsurfaceRef/workspaceRef; the answers carrysurfaceId/workspaceId. One test title still said "positional ref".Left by the image editor (#1148)
docs/specs/tutorial.md: the playground refuses view-only PNG/JPEG too (PlaygroundViewers.openinwebsite/src/lib/playground-fs/viewers.ts), not only non-image formats.dor-tools-builtin/viewer/images-panel.tsx:localImagePath's path is what theimages/,edit/, andimage-save/routes take, notfile/.Elsewhere
docs/specs/security-audit.mdEmbargo table: a disclosure issue is one per ledger issue, matching the Disclosure section andarchiveIdinscripts/security-audit-public-body.mjs(a finding that returns after its fix gets a second disclosure).docs/specs/security-local.rationale.md:remote_host_state_dirdoesn't exist; the DACL-locked directory isburrow_state_dir.lib/src/remote/burrow/store.ts: dropped the claim thatENROLLMENT_KEYlives apart so the extension host avoidsremote-lib-common;vscode-ext/src/burrow-store.tsalready importsenrollment.ts, which pulls it in.terminal-state-store.ts:ALT_GROUND_SCANis global (/g), not sticky.pty-core.js: thepsbranch is macOS only.App.test.tsx:installNotice()returnsnullwhen missing, sonot.toBeUndefined()could never fail; it now assertsnot.toBeNull().No regression test: the only code change removes an unreachable loop.