Skip to content

Correct stale comments left by numbered ids and the image editor, and drop a dead Workspace id retry - #1164

Merged
nedtwigg merged 1 commit into
mainfrom
nightly/stale-comments-2026-10-17
Oct 17, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
nightly/stale-comments-2026-10-17

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Comments, one spec table cell, two rationale/spec sentences, and test type annotations still described behavior that recent merges changed. One dead helper goes with them. Nothing here changes runtime behavior; CI's typecheck and test suites are the verification.

Left by numbered Surface/Workspace ids (#1085)

  • standalone/src-tauri/src/lib.rs: the registry field said Workspaces sit "under their stable refs" (refs are gone), and ClosedWindow said its snapshot was built "with fresh ids", though windowReopenSnapshot now keeps the closed window's ids marked reopened (as push_closed_window's own doc already says).
  • lib/src/lib/workspace-store.ts: freshWorkspaceId retried generateWorkspaceId() until no Workspace held the id, but the id pool's mint already loops on inUse: hasWorkspace — the same test — so the retry could never run. Callers now call generateWorkspaceId() directly.
  • use-dor-control.ts / use-tool-run-end.ts comments, and test response types in reopen.test.tsx and WorkspaceWindow.test.tsx, still named surfaceRef/workspaceRef; the answers carry surfaceId/workspaceId. One test title still said "positional ref".

Left by the image editor (#1148)

  • docs/specs/tutorial.md: the playground refuses view-only PNG/JPEG too (PlaygroundViewers.open in website/src/lib/playground-fs/viewers.ts), not only non-image formats.
  • dor-tools-builtin/viewer/images-panel.tsx: localImagePath's path is what the images/, edit/, and image-save/ routes take, not file/.

Elsewhere

  • docs/specs/security-audit.md Embargo table: a disclosure issue is one per ledger issue, matching the Disclosure section and archiveId in scripts/security-audit-public-body.mjs (a finding that returns after its fix gets a second disclosure).
  • docs/specs/security-local.rationale.md: remote_host_state_dir doesn't exist; the DACL-locked directory is burrow_state_dir.
  • lib/src/remote/burrow/store.ts: dropped the claim that ENROLLMENT_KEY lives apart so the extension host avoids remote-lib-common; vscode-ext/src/burrow-store.ts already imports enrollment.ts, which pulls it in.
  • terminal-state-store.ts: ALT_GROUND_SCAN is global (/g), not sticky. pty-core.js: the ps branch is macOS only.
  • App.test.tsx: installNotice() returns null when missing, so not.toBeUndefined() could never fail; it now asserts not.toBeNull().

No regression test: the only code change removes an unreachable loop.

…e audit disclosure split

Also drop workspace-store's freshWorkspaceId, whose retry loop the id pool's
own in-use check already makes unreachable, and make a Pocket install-notice
test assert against null, which installNotice returns.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e4eae9
Status: ✅  Deploy successful!
Preview URL: https://490b889c.mouseterm.pages.dev
Branch Preview URL: https://nightly-stale-comments-2026.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit 949a097 into main Oct 17, 2026
16 of 17 checks passed
@nedtwigg
nedtwigg deleted the nightly/stale-comments-2026-10-17 branch October 17, 2026 15:56

This branch is waiting to be deployed

1 waiting deployment
hosted-preview — 0e4eae99 Waiting Oct 17, 2026 by dormouse-bot via deploy #1449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants