Skip to content

manifest: annotate: add shell-completion for --os and --arch - #7449

Open
thaJeztah wants to merge 1 commit into
docker:masterfrom
thaJeztah:manifest_completion
Open

thaJeztah wants to merge 1 commit into
docker:masterfrom
thaJeztah:manifest_completion

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

With this patch;

docker manifest annotate --os <TAB>
aix        darwin     freebsd    illumos    js         nacl       openbsd    solaris    zos
android    dragonfly  hurd       ios        linux      netbsd     plan9      windows

docker manifest annotate --arch <TAB>
386          arm          armbe        mips64       mips64p32le  ppc64        riscv64      sparc
amd64        arm64        loong64      mips64le     mipsle       ppc64le      s390         sparc64
amd64p32     arm64be      mips         mips64p32    ppc          riscv        s390x        wasm

Summary

Release notes (optional)

manifest annotate: add shell-completion for --os and --arch

A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

docker-agent

This comment was marked as outdated.

@thaJeztah

Copy link
Copy Markdown
Member Author

Ah; expected this to happen (but forgot to run validate locally 😂);

cli/command/manifest/annotate.go:29: line-length-limit: line is 261 characters, out of limit 200 (revive)

With this patch;

    docker manifest annotate --os <TAB>
    aix        darwin     freebsd    illumos    js         nacl       openbsd    solaris    zos
    android    dragonfly  hurd       ios        linux      netbsd     plan9      windows

    docker manifest annotate --arch <TAB>
    386          arm          armbe        mips64       mips64p32le  ppc64        riscv64      sparc
    amd64        arm64        loong64      mips64le     mipsle       ppc64le      s390         sparc64
    amd64p32     arm64be      mips         mips64p32    ppc          riscv        s390x        wasm

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

@thaJeztah
thaJeztah requested a review from vvoland October 30, 2026 14:42

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants