Skip to content

Make LatencyPlugin's maxMs inclusive #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldekmastykarz merged 5 commits into from
Oct 21, 2026
Merged

Make LatencyPlugin's maxMs inclusive #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6260959
Initial plan
Copilot Oct 20, 2026
bf75426
Make LatencyPlugin maxMs inclusive. Closes #1927
Copilot Oct 20, 2026
5e9e905
Apply remaining changes
Copilot Oct 20, 2026
437ffc9
Merge branch 'main' into copilot/fix-latencyplugin-maxms-issue
waldekmastykarz Oct 21, 2026
1ee7fa8
Update dependent NuGet lock files
Copilot Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions DevProxy.Integration.Tests/BehaviorPluginsIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,23 @@ public async Task Latency_AddsConfiguredDelayBeforeForwarding()
$"Expected >= {minMs - 100}ms of injected latency, saw {stopwatch.ElapsedMilliseconds}ms.");
}

[Fact]
public void Latency_DelayRangeIncludesMaxMs()
{
var random = new Random(42);
var seen = new HashSet<int>();
for (var i = 0; i < 1000; i++)
{
var delay = LatencyPlugin.GetDelay(random, 0, 1);
Assert.InRange(delay, 0, 1);
_ = seen.Add(delay);
}

Assert.Contains(1, seen);
Assert.Equal(5, LatencyPlugin.GetDelay(random, 5, 5));
Assert.InRange(LatencyPlugin.GetDelay(random, int.MaxValue - 1, int.MaxValue), int.MaxValue - 1, int.MaxValue);
}

[Fact]
public async Task RateLimiting_ThrottlesOnceResourcesAreExhausted()
{
Expand Down
8 changes: 6 additions & 2 deletions DevProxy.Plugins/Behavior/LatencyPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,19 @@ public override async Task AfterStderrAsync(StdioResponseArgs e, CancellationTok

private async Task ApplyDelayAsync(string context, LoggingContext loggingContext, CancellationToken cancellationToken)
{
var delay = _random.Next(Configuration.MinMs, Configuration.MaxMs);
var delay = GetDelay(_random, Configuration.MinMs, Configuration.MaxMs);
Logger.LogRequest($"Delaying {context} for {delay}ms", MessageType.Chaos, loggingContext);
await Task.Delay(delay, cancellationToken);
}

private async Task ApplyDelayAsync(string context, StdioLoggingContext loggingContext, CancellationToken cancellationToken)
{
var delay = _random.Next(Configuration.MinMs, Configuration.MaxMs);
var delay = GetDelay(_random, Configuration.MinMs, Configuration.MaxMs);
Logger.LogRequest($"Delaying {context} for {delay}ms", MessageType.Chaos, loggingContext);
await Task.Delay(delay, cancellationToken);
}

// maxMs is inclusive; use a 64-bit upper bound to avoid overflow when maxMs is int.MaxValue
internal static int GetDelay(Random random, int minMs, int maxMs) =>
(int)random.NextInt64(minMs, (long)maxMs + 1);
}
Loading