Repository navigation
fix(test): invert results only for not-fixed @Issue tests - #1600
Merged
Merged
Conversation
rubenporras
previously approved these changes
Nov 4, 2026
joaodinissf
force-pushed
the
fix/issue-aware-rule-fixed
branch
from
November 4, 2026 11:55
9ce2cda to
c68b0ff
Compare
rubenporras
previously approved these changes
Nov 4, 2026
IssueAwareRule expects a test to fail, and reports it as an error when it passes, only if it is annotated @issue(fixed = false); tests for fixed issues run unchanged. This matches the Issue javadoc, the rule's own javadoc and its JUnit 4 predecessor. The JUnit 5 port dropped the negation, so tests for fixed issues were inverted and not-fixed ones ran normally. IssueAwareRuleTest covers these results directly. test.core is bumped to 18.0.2 because its content changed against the 19.3.3 baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SWTBotRadio#click() now selects the radio button correctly, so testSWTRadioButtonClick passes and runs as a regular test. With the corrected IssueAwareRule a fixed = false marker would report it as an unexpected pass. The rule registration is removed with its only user. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joaodinissf
force-pushed
the
fix/issue-aware-rule-fixed
branch
from
November 4, 2026 14:00
c68b0ff to
a5bcb88
Compare
joaodinissf
marked this pull request as ready for review
November 4, 2026 14:00
joaodinissf
enabled auto-merge
November 4, 2026 14:00
rubenporras
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IssueAwareRuleinverts a test's result only when it is annotated@Issue(fixed = false): such a test must fail, and passing is reported as an error. Tests for fixed issues run unchanged. This matches theIssuejavadoc, the rule's own javadoc and its JUnit 4 predecessor; the JUnit 5 port had dropped the negation.IssueAwareRuleTest, registered inXtextTestSuite, covers the rule's results for fixed and not-fixed issues. Four of its five tests fail against the old condition; the fifth, error propagation, passes on both.SwtBotRadioTest.testSWTRadioButtonClickno longer carries the stale@Issue(value = "DSL-371", fixed = false)marker, because the test passes when this bundle's tests are run (test: run each test bundle in its own runtime with JUnit discovery #1599). The test class no longer registers the rule.com.avaloq.tools.ddk.test.coreis bumped to 18.0.2 for its changed content against the 19.3.3 baseline.Overlap
Overlaps with draft #1599 (test discovery) on
SwtBotRadioTestandXtextTestSuite, which #1599 deletes; whichever merges second will rebase.Test plan
./mvnw -T 3C -f ddk-parent/pom.xml clean verify checkstyle:check pmd:pmd pmd:cpd pmd:check pmd:cpd-check spotbugs:check --batch-mode --fail-at-endgreen locally on Temurin 21, includingcompare-version-with-baselinesIssueAwareRuleTestrun against the old condition: 4 of 5 tests fail🤖 Generated with Claude Code