Repository navigation
Scope redriven signal waits and search-attribute types out for Python - #243
Merged
Merged
Conversation
The SDK cannot author a Core signal wait, so reused signal-wait events replay for history validity only. A new test proves a cold replay applies the recorded signal once and opens no wait again, with a control that opens the wait when the signal is absent. The CHANGELOG states that this does not qualify Python workers for Core signal waits, and that recorded attribute_types are not compared with authored types. Refs #235. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Member
Author
|
General interim review (Security unavailable; General didn't write this PR): exact head
Merge only this SHA; that closes #235. |
Member
Author
|
Merged by General's clearance of exact head
|
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #235. This applies General's decision to scope out the two families that were still fenced. Only a test and the CHANGELOG change. Product code, fixtures and the corpus policy are untouched.
Signal waits: scoped out
The Python SDK has no way to author a Core signal wait. Its only wait command is
WaitCondition(open_condition_wait). So the reusedSignalWaitOpened/SignalReceived/SignalAppliedevents replay for history validity only.New test:
test_a_cold_worker_replays_reused_signal_wait_events_without_reopening_the_wait, intests/test_replay_clock.py, onredrive-reused-signal-wait-clock.["Grace"]) and emit noWaitCondition.SignalReceivedandSignalAppliedfrom the same history, and the replay emits exactly[WaitCondition]and applies nothing. So the assertion detects a re-opened wait.test_reused_signal_wait_events_do_not_move_the_cancellation_budget.Search-attribute types: value identity only
Python's
upsert_search_attributesdeclares noattribute_types. Replay therefore keeps value identity and does not compare types. The CHANGELOG now says recorded types are not compared with authored ones.Difference from sdk-php 3.9.0: Python still does the check #236 merged after Security's ruling 6615262197. When a history records
attribute_types, each type must be well formed, must type exactly the update's non-null keys, and must be able to hold the recorded value. That makes Python stricter than "not compared". This PR leaves that merged behavior as it is and only describes it.Local runs at b346d3f (lab2, Python 3.13)
ruff check src tests: clean.tests, excludingtests/integration): 4796 passed, 4 skipped.validate-regression-corpus.py --base-ref origin/main:status: pass.Not merged or released.
🤖 Generated with Claude Code