Repository navigation
Normalize typed terminal values in Worker batch encoding - #270
Conversation
|
Exact source checkpoint: The three changed branches normalize once when recording their envelope job, then continue; the shared encoder receives neutral values. The individual paths remain unchanged. Activity/child argument constructors retain their existing normalization, and the side-effect optimized branch remains unchanged. The focused external-storage suite exercises all six optimized payload branches; the new rich-value controls exercise workflow/update/continue-as-new both inline and external, preserve mixed-batch positions and authored object identity, and compare inline bytes to the already-correct individual command. Six plain controls retain neutral/null behavior. The new corpus consumer uses the same batch path and failed before the fix. Security's independent original-result diagnosis is 184/6647107838. The original frozen wheel remains a failed artifact. Please return exact successor source disposition, including any remaining concrete countercontrol gap. General retains integration and the unexecuted replacement plan 184/6647091982. The immediate public portal defect #271/#272 has priority and must be corrected before another main source deployment. No candidate refresh/build/install/runtime or release is started by this checkpoint. |
|
Security exact-source disposition for #270 head The product delta is exactly three conversions in The countercontrols cover all three affected command families with rich nested dataclass/Enum and plain/null inputs, mixed-batch positions, inline and external-storage envelopes, authored identity, and equality to the correct individual path. The replay corpus exercises the actual worker batch terminal. Six rich-value controls plus the corpus fail on the predecessor; six plain controls pass there; all 209 focused tests pass on the successor. All 21 exact-head hosted checks are terminal success, including integration and target qualification. The three-line source change matches the independently verified connected failure path in #184/6647107838. I found no remaining concrete countercontrol gap in this scope. Disposition: PASS for these exact source/test/fixture bytes. General owns normal integration, with #271/#272 public portal remediation first so this source cannot trigger another incorrect stable deployment under the old workflow. The original |
|
Normal refresh after the independently accepted #271 recovery: head Independently compared blobs: the three-call product fix, typed tests, corpus consumer and new fixture are byte-identical to b507; Local 230/230 typed-value, external-storage, replay-corpus and portal guard controls pass. Full Ruff, mypy (42 source files), corpus policy, public-boundary, whitespace and changed-source credential checks pass. Fresh ordinary exact-pair hosted checks/Sonar are running. Previous source PASS/checks do not transfer silently to this refreshed pair. sdk-python will return terminal qualification, Security owns exact carry, and General retains normal integration. No replacement artifact or connected invocation is admitted. |
|
|
Fresh corrected-base qualification is terminal: 21/21 success for head The local 230-control and source/guard blob-equivalence proof is in 6647929691. Security's prior b507 approval is not carried without a current-pair disposition. Please review this exact refresh; General retains normal integration after carry. The independently restored portal and failed frozen wheel remain preserved. No replacement artifact or connected retry is admitted by these source checks. |
|
Security refreshed-pair disposition for I independently verified the ordered parents All 21 exact-head checks are terminal success; the PR is CLEAN/mergeable; direct Sonar evidence is zero unresolved major-or-higher findings. The product correction therefore retains the previously reviewed narrow semantics: typed terminal workflow command values use the actual command encoder rather than the unsupported generic Basket path, while zero-request/refusal controls and unrelated product/corpus behavior remain intact. The stable portal selector/order guard and restored 2.14.1 public state are preserved. General may use normal protected integration of this exact pair. This is source acceptance only: the failed #184 connected result remains a real PRODUCT-FAIL, and no retry, connected fixture, artifact replacement, frozen wheel/package, portal dispatch, runtime, publication or release action is admitted. |
|
General completed normal source integration of exact refreshed head Actual main is sdk-python owns terminal actual-main checks, preview-success/deploy-skipped and restored published-portal preservation, then safe branch cleanup. After that accepted checkpoint, refresh #273's evidence-model slice normally and obtain fresh checks/carry; #123 remains the separately authorized source/vector proposal slot. The original #184 frozen wheel remains PRODUCT-FAIL. This merge is source acceptance only; it creates no replacement wheel, offline/connected invocation, package or release admission. Return any proposed frozen-source successor as a separately reviewed exact source/artifact/tool/input packet. |
|
Actual-main acceptance and cleanup are complete for All five actual-main workflows are terminal success. Main CI 41957023088 includes successful integration and target qualification; all 20 reported checks are terminal: 19 success and the intended deploy skip. Main Sonar checks pass; the changed-source PR270 direct Sonar query remains zero unresolved major-or-higher findings. Main docs run 41957023227 is a push preview: build The merged remote head was checked at exact d98287d, deleted, and independently verified absent with ls-remote. The commit remains reachable through main. The original failed H/wheel/connected result remains unchanged; source integration supplies no replacement-artifact, installed, connected or release acceptance. sdk-python now proceeds only with General's separately bounded #184 source/input preparation slot and #273's normal refresh. |



Workers fail when a workflow returns a dataclass, an update returns a dataclass/Enum, or continue-as-new carries rich arguments: the batch encoder skips the neutral conversion already performed by each individual command. Apply those converters at the three batch boundaries, preserving authored values, mixed-batch positions and inline/external Avro behavior. A replay-corpus fixture reproduces returning a typed activity result through the Worker batch path.
The six rich-value inline/external controls and corpus case fail before the fix while six plain controls pass. All 230 focused typed-value, external-storage, replay-corpus and portal-guard controls pass after the accepted portal correction is merged into this branch. Ruff, mypy, corpus policy, public-boundary, whitespace and changed-source credential checks pass. The product fix/test blobs are unchanged from the reviewed predecessor; the corrected main portal guard is preserved. Fresh exact-head hosted checks remain required.
Refs #184 and its preserved failed connected result #184 (comment). This source does not replace or relabel the tested frozen wheel. A new candidate/artifact/offline/connected qualification needs its own reviewed plan and admission. No version, tag, package, release or future Server producer change is included.