Repository navigation
Capture observations around worker shutdown without masking errors - #279
Conversation
|
|
Owner source review at exact205c69c0aacf6ad5b3b1da8457f02b62c82d5754/tree7444fb4d399b0dd4cc25e150af722d01a778727b, base78ff7a18: all20 exact-head checks are terminal SUCCESS, including CI42091030737, six supported Python versions, integration and target-branch qualification, Sonar, CodeQL and public boundary. Forty-three focused local tests, touched-file Ruff and mypy42 source files pass. Reviewed the four-file change: symmetric bounded observations, separate monotonic brackets and invalid-capture records surround the existing shutdown; all primary-error/cancellation identities and runner drainage survive reporting/shutdown faults. No SDK product, workflow, budget or API/SQL probe changes. Historical source pins and full comparator/cleanup requirements remain separately documented. Publication followers checked: no workflow_run publisher, no release tag/manual publish event, and these test-only paths exclude docs deployment. Current accepted source retains the protected stable-tag guard. Proceeding through normal owner integration with exact-head matching and no branch-protection bypass, followed by actual-main checks and branch cleanup. Ordinary source CI does not qualify an historical tuple or the failed/unbuilt frozen candidate. |
|
#279 actual-main follow-through is complete. Merge b0095ad has reviewed tree 7444fb4d399b0dd4cc25e150af722d01a778727b, ordered parents[78ff7a1,205c69c0]. All18 actual-main checks pass, and all four workflows are terminal SUCCESS: CI42092279154, Sonar42092279052, CodeQL42092279020 and public-boundary42092279395. No docs/publication workflow was selected by these test-only paths; the protected stable-tag workflow blob is unchanged. Fresh five-page live hashes/byte counts match restored published2.14.1 artifact13380779871, with queued/running/waiting/pending/requested docs-writer counts all zero. This source qualification supplies no historical tuple, frozen artifact or publication acceptance. The exact remote branch205c69c0 was deleted and independently read back404; its clean isolated worktree/local branch were removed. Shared main is clean atb0095ad1. #123 stays open: bounded before/after observations and primary-error preservation are delivered; original-row SQL/API collection, private claim/registration comparators, full phase linkage and historical execution remain incomplete. The next unexecuted SQL proposal is draft#280; Server returned bounded field/text review, its documentation-only zero-row clock clarification and fresh exact-head CI are in progress. sdk-python owns that source follow-through and remaining preparation, with no additional historical execution or #184 operating action admitted. |
Successful worker cases previously skipped the full pre-shutdown observation, and a reporting failure could replace the original case error. The ordinary task-family driver now captures bounded reports before and after shutdown on success and failure, with separate monotonic brackets and an explicit invalid capture state. Reporting failures still run stop/drain; an existing primary exception keeps its identity even when reporting or shutdown also fails.
The shared helper preserves the existing worker/result/shutdown behavior and timeout values. It adds no SQL/API probe, historical runtime, or outer cleanup deadline. Capture availability remains separate from retained-buffer completeness, phase linkage and the original #123 cause; the reconstruction README records those remaining requirements.
Validation: 43 focused source tests pass, including success/failure/report/emitter/shutdown combinations with original errors and cancellation, runner drainage, redaction and immutable bracketed snapshots. Ruff on all three changed Python files, mypy on42 SDK source files, diff and credential-pattern checks pass. Normal source CI follows; no artifact publication or historical/frozen qualification is implied.
Part of #123; the issue remains open for SQL/API original-row snapshots, full phase linkage and separately admitted historical execution.