Repository navigation
Rust #325: repair the remaining missing wait tasks - #901
Merged
Merged
Conversation
Native's repair command and repair pass now create the missing task of a run waiting on a received signal, an accepted update, a resolved child, or a condition or signal wait's timeout, as published Server 2.11.7's TaskRepair::createMissingTask does: - a received signal, accepted update or resolved child gets a workflow task with forSignal's, forUpdate's or the child run's resume payload; - a pending timeout gets its timer task again, available at the deadline; - a fired timeout gets the workflow task that applies it. A run with a received signal and no open task is now projected as PHP projects it, waiting to apply the signal and needing repair, so the command no longer answers repair_not_needed for it. The development_workflow_task_repair_unqualified refusal is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Member
Author
|
Sonar's one new issue is rust:S3776, cognitive complexity 39 against 30, on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #325.
Native's repair command and repair pass now create the missing task for the wait cases #887 still refused. Each case matches published Server 2.11.7 (
TaskRepair::createMissingTaskwithWorkflowTaskPayload::forMissingWorkflowTask):forSignal's payloadforUpdate's payload; the update's open wait moves to it{workflow_wait_kind, open_wait_id, resume_source_kind: child_workflow_run, resume_source_id, child_call_id, child_workflow_run_id}Every created task is ready with
repair_count1.signalwait ("Waiting to apply signal …",signal-application:<id>) with livenessrepair_needed. Before, native left it without a summary, so the repair command answeredrepair_not_needed.development_workflow_task_repair_unqualifiedrefusal and the pass's unported-recovery path are gone.PHP findings. I recorded seven cases against the published image with each run's open task row deleted and maintenance stopped:
repair_dispatched, and the run was described as before;repair_not_neededfor the signal.The new checkpoint is
docs/rust-server-port-checkpoints/2026-11-01-repair-missing-wait-tasks.md. It records two small native differences: the repaired timeout timer task keeps a condition occurrence id, and native's own accepted-update task payload is narrower thanforUpdate.Checks run locally
cargo test(all suites, SQLite): passed (368 lib, 649 execution, 2 upgrade_inspect).workflow_repairtests on PostgreSQL 17 and MySQL: 4/4 passed on each.completion_budgetandworker_poll_fence, withstale_worker_registration. They ran while the host was overloaded and the MySQL suite ran alongside, and this change doesn't touch those paths.ServerParityUpdateValidationTimingTest.mjs: 6459 passed, 1 failed. The failure isPhpImageContextTest, which needs adockerCLI the test container doesn't have.🤖 Generated with Claude Code