Repository navigation
Add ariaLabelledBy prop to Dialog - #2577
Closed
anuj-pal27 wants to merge 1 commit into
Closed
anuj-pal27 wants to merge 1 commit into
anuj-pal27 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks again for your time and aportation, but exposing the ariaLabelledBy is not the correct solution in our opinion. We are not forcing any type of Heading or Title in the dialog. Additionally the contents of any Heading might not match as label of the Dialog and as you correctly mentioned we are not exposing any kind of id prop in our components so it does not make sense to expose the ariaLabelledBy. We are still grateful for your interest in improving our design system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Description
DxcDialogalways had a hardcodedaria-label="Dialog", so every dialog was announced the same way regardless of its content. Following the W3C dialog pattern, this adds an optionalariaLabelledByprop that setsaria-labelledbyto reference the dialog's title. If it isn't provided, the dialog keepsaria-label="Dialog", so the change is non-breaking.Additional context
DxcHeadingdoesn't accept anid, so to use it as the title it has to be wrapped in an element with an id. Adding anidprop toDxcHeadingcould be a follow-up if wanted.Closes #2139