Skip to content

[major] Update prefix/susffix accessibility - #2580

Open
PelayoFelgueroso wants to merge 1 commit into
masterfrom
PelayoFelgueroso/prefix-sufix-accessibility
Open

PelayoFelgueroso wants to merge 1 commit into
masterfrom
PelayoFelgueroso/prefix-sufix-accessibility

Conversation

@PelayoFelgueroso

Copy link
Copy Markdown
Collaborator

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Update prefix and suffix at TextInput to fix accessibility issues

const color = disabled ? "var(--color-fg-neutral-medium)" : "var(--color-fg-neutral-stronger)";
return `color: ${color}; border-${type === "prefix" ? "right" : "left"}: var(--border-width-s) var(--border-style-default) ${color};`;
const textColor = disabled ? "var(--color-fg-neutral-medium)" : "var(--color-fg-neutral-stronger)";
const borderColor = disabled ? "var(--color-fg-neutral-lighter)" : "var(--color-fg-neutral-strong)";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be border colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants