Repository navigation
Conversation
Text and StyledText test_backspaceAndDelete only open the shell before Display.post, so on a busy machine the shell can stay behind another window and the posted keys go there ("expected: <1> but was: <0>" on Windows 11, where a background process may not take the foreground). SwtTestUtil.forceActiveForPost activates the shell, and outside GTK, where getActiveShell is reliable, waits for it and skips the test when it still is not active.
Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text and StyledText test_backspaceAndDelete only open the shell before calling Display.post, so on a busy machine the shell can stay behind another window and the posted keys go there; on Windows 11 this fails with "expected: <1> but was: <0>", because a background process may not take the foreground. The new SwtTestUtil.forceActiveForPost activates the shell before the keys are posted, and on Windows and Cocoa waits for it and skips the test instead of failing when it cannot become active. On GTK it only requests activation, since getActiveShell reports the wrong shell there (#726). This makes the two tests reliable on developer machines and keeps posted keys out of other applications' windows; they stay disabled on Jenkins as described in #2571.