Repository navigation
Do not paint the selected tab fill in a CTabFolder without selected tab - #4570
Conversation
When all editors are closed, the empty editor area on Windows shows a band in the selected tab color below its empty tab row and around the content area, as if an invisible tab were selected. With themes whose selected tab fill differs from the folder background (e.g. white tab cards on a gray folder), this makes an empty editor area look like a broken, half-drawn editor. The cause is the custom tab content background (swt-draw-custom-tab-content-background, enabled for the editor area by the default Windows theme): CTabRendering extends the selected tab fill over the whole area below the tab row, regardless of whether there is a selected tab at all. A folder without selected tab, in particular an empty one, now keeps its folder background below the tab row. The tab row itself is drawn as before, and folders with a selected tab are unchanged. The selected tab fill is the background of the selected tab's content, so it is only drawn when the folder has a selection. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Is this specific on Windows or does this also happen on other OSes? |
Good question. It also happens on macOS. So I have removed the statement on Windows from the PR description. |
|
@vogella do you think this should still go into the 2026-12 release? I think it's very low risk and improved appearance, but the appearance is also pre-existing for a long time, so it may not be considered urgent either. |
I personally see zero risk here and it improves the L&F of Eclipse, so I'm in favor of merging. We also still have some time before the release goes out, so in the unlikely event that this change breaks something, we can still revert. |
|
Alright, thank you. Then let's do it. |


Problem
When all editors are closed, the empty editor area still looks as if an invisible editor tab were selected. Below the empty tab row and around the content area it shows a band in the color of the selected tab. With themes in which the selected tab color differs from the folder background, for example white tab cards on a gray folder, an empty editor area looks like a broken, half-drawn editor.
The cause is the custom tab content background (
swt-draw-custom-tab-content-background), which the shipped themes enable for the part stacks. With it,CTabRenderingextends the selected tab fill over the whole area below the tab row, whether or not the folder has a selected tab.Solution
The selected tab fill is the background of the selected tab's content, so it is now only painted when there is a selected tab. A folder without a selected tab, in particular an empty editor area, keeps its folder background below the tab row. The tab row itself is drawn as before, and folders with a selected tab look exactly as they did.
Testing
Use the Light theme
on Windowsand close all editors. Before this change, a white band runs between the tab row and the area with the onboarding hints, and thin white edges run along its sides. With this change, that band and the edges show the folder background, the same light gray as the tab row.🤖 Generated with Claude Code