Repository navigation
Conversation
The renderer updated the manager of every menu after model changes, which filled the items of top-level menus nobody had opened yet at startup. A closed drop-down menu now stays dirty and MenuManager fills it when the menu is shown. Menus with native accelerators keep being updated while closed, since those accelerators only work while their menu item exists. Part of eclipse-platform#4566 Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a model change the renderer updated the manager of every affected menu, which also filled the items of top-level menus nobody had opened yet. A closed drop-down menu now stays dirty and MenuManager fills it when it is shown, as it already does for deeper submenus. The menu bar, open menus and view menus (pop-up menus) still update immediately. Menus with native accelerators, that is actions whose accelerator is not handled by a key binding, also in submenus, keep being updated while closed, since such accelerators only work while their menu item exists. New tests cover filling on show, items added, hidden or no longer rendered while the menu is closed, and the accelerator case.
Part of #4566