Skip to content

Fill closed drop-down menus when they are shown - #4572

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:fill-menus-on-show
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:fill-menus-on-show

Conversation

@vogella

@vogella vogella commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

After a model change the renderer updated the manager of every affected menu, which also filled the items of top-level menus nobody had opened yet. A closed drop-down menu now stays dirty and MenuManager fills it when it is shown, as it already does for deeper submenus. The menu bar, open menus and view menus (pop-up menus) still update immediately. Menus with native accelerators, that is actions whose accelerator is not handled by a key binding, also in submenus, keep being updated while closed, since such accelerators only work while their menu item exists. New tests cover filling on show, items added, hidden or no longer rendered while the menu is closed, and the accelerator case.

Part of #4566

The renderer updated the manager of every menu after model changes,
which filled the items of top-level menus nobody had opened yet at
startup. A closed drop-down menu now stays dirty and MenuManager fills
it when the menu is shown. Menus with native accelerators keep being
updated while closed, since those accelerators only work while their
menu item exists.

Part of eclipse-platform#4566

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella vogella added the plan Planned bugs/enhancements for a release label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ± 0     867 suites  ±0   1h 2m 26s ⏱️ - 8m 31s
 8 549 tests + 4   8 309 ✅ + 4  240 💤 ±0  0 ❌ ±0 
21 519 runs  +12  20 846 ✅ +12  673 💤 ±0  0 ❌ ±0 

Results for commit 13f9ac3. ± Comparison against base commit d0e3468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan Planned bugs/enhancements for a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant