Skip to content

Keep the Forms editor background after a switch to the light theme - #4573

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:light-theme-editor-forms
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:light-theme-editor-forms

Conversation

@vogella

@vogella vogella commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

After a runtime switch from the dark to the light theme, FormText and the master/details sash in Forms editors such as the PDE manifest editor kept the widget default background instead of the FormToolkit color. The theme switch resets the colors CSS has set, and the light theme only styled Forms widgets in views. The light theme now gives them the toolkit color in editors too, so a switch looks the same as a fresh start.

A theme switch resets the colors CSS has set, so FormText and the
master/details sash in editors such as the PDE manifest editor lost the
FormToolkit background and fell back to the widget default. The light
theme only styled Forms widgets in views; it now gives them the toolkit
color in editors too.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella

vogella commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author
before-after-light-to-dark

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   43m 6s ⏱️ - 27m 51s
 8 545 tests ±0   8 305 ✅ ±0  240 💤 ±0  0 ❌ ±0 
21 507 runs  ±0  20 834 ✅ ±0  673 💤 ±0  0 ❌ ±0 

Results for commit f1f41a4. ± Comparison against base commit d0e3468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant