Repository navigation
Conversation
A theme switch resets the colors CSS has set, so FormText and the master/details sash in editors such as the PDE manifest editor lost the FormToolkit background and fell back to the widget default. The light theme only styled Forms widgets in views; it now gives them the toolkit color in editors too. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After a runtime switch from the dark to the light theme, FormText and the master/details sash in Forms editors such as the PDE manifest editor kept the widget default background instead of the FormToolkit color. The theme switch resets the colors CSS has set, and the light theme only styled Forms widgets in views. The light theme now gives them the toolkit color in editors too, so a switch looks the same as a fresh start.