Skip to content

Do not activate plug-ins for menus that are not shown - #4574

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:defer-menu-plugin-activation
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:defer-menu-plugin-activation

Conversation

@vogella

@vogella vogella commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Evaluating visibleWhen for menus that are not shown forced the activation of property tester plug-ins, for example m2e's Project menu entry whenever a Maven resource was selected (eclipse-m2e/m2e-core#2237). Submenus evaluated by updateElementVisibility, including the main menu pass of WorkbenchWindow, and the visibility trackers of view menus now evaluate without plug-in activation. A tester that is not loaded yet counts as visible until the menu is shown, where the show processor evaluates it with activation, since NOT_LOADED results were already treated as visible. Two new tests in MenuManagerRendererTest cover both halves.

Part of #4566

Evaluating visibleWhen expressions for closed menus forced the
activation of property tester plug-ins, for example m2e's Project menu
entry whenever a Maven resource was selected. Submenus evaluated by
updateElementVisibility and the visibility trackers of view menus now
evaluate without plug-in activation, so an unloaded tester counts as
visible until the menu is shown and evaluated with activation.

Part of eclipse-platform#4566

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella vogella added the plan Planned bugs/enhancements for a release label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   1h 8m 58s ⏱️ - 1m 59s
 8 547 tests +2   8 307 ✅ +2  240 💤 ±0  0 ❌ ±0 
21 513 runs  +6  20 840 ✅ +6  673 💤 ±0  0 ❌ ±0 

Results for commit 2c926ea. ± Comparison against base commit d0e3468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan Planned bugs/enhancements for a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant