Repository navigation
Conversation
Evaluating visibleWhen expressions for closed menus forced the activation of property tester plug-ins, for example m2e's Project menu entry whenever a Maven resource was selected. Submenus evaluated by updateElementVisibility and the visibility trackers of view menus now evaluate without plug-in activation, so an unloaded tester counts as visible until the menu is shown and evaluated with activation. Part of eclipse-platform#4566 Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluating
visibleWhenfor menus that are not shown forced the activation of property tester plug-ins, for example m2e's Project menu entry whenever a Maven resource was selected (eclipse-m2e/m2e-core#2237). Submenus evaluated byupdateElementVisibility, including the main menu pass ofWorkbenchWindow, and the visibility trackers of view menus now evaluate without plug-in activation. A tester that is not loaded yet counts as visible until the menu is shown, where the show processor evaluates it with activation, sinceNOT_LOADEDresults were already treated as visible. Two new tests inMenuManagerRendererTestcover both halves.Part of #4566