Repository navigation
Conversation
Returns the selected elements of the given type as an unmodifiable list, replacing the common filter and cast stream idiom. Fixes eclipse-platform#1376 Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Test Results 578 files - 289 578 suites - 289 29m 11s ⏱️ - 21m 48s Results for commit abc0ead. ± Comparison against base commit b5dd338. This pull request skips 8 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the selected elements of a specific type out of an IStructuredSelection currently needs a raw-type cast or a stream().filter(...).map(...) chain at every call site. This adds a default toList(Class) method that returns the selected elements of the given type, in selection order, as an unmodifiable List, so callers can write viewer.getStructuredSelection().toList(IResource.class). Since it is a default method, existing implementations pick it up without changes.
Fixes #1376