Repository navigation
Diff ARM punctuation - #424
Merged
Merged
Conversation
Treats `[`, `]`, `!`, `rrx`, `^` and `-` (as in `[rn, -rm]` derefs) as opaque arguments so they are included in the diff algo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two ARM32 instructions differ only by punctuation, the diff algorithm considers them equivalent. This PR fixes that by overriding more functions from
unarm::FormatInsto cause such punctuation to be opaque arguments rather than basic text.A couple examples:
More precisely, the following instruction fragments went from basic text to opaque arguments:
[and]!rrx^-as in[rn, -rm]rorThis change is based on the newly released unarm 2.3.0 which adds some of the
FormatInsfunctions that were overriden here. A side effect of this version bump is that unarm 2.2.0 fixes some obscure bugs not related to this PR.