Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Local YAML resolution does not establish whether GitHub and repository glint accept env-defined scalar aliases in uses, so CI/parser acceptance must be confirmed before adopting the publishing workflow.
No open issues 🎉
What changed in this PR
This PR trials a centralized YAML-anchor register for toolshed action pins in the release publishing workflow, reducing repeated edits without changing the pinned versions.
Changes:
- Adds four anchored action references under workflow-level
env. - Replaces five
usesvalues with aliases, sharing the Appauth reference across both jobs. - Keeps the experiment scoped to
publish.yml.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Centralizes toolshed action references and reuses them through YAML aliases. |
Review effort: Balanced
phlax
force-pushed
the
toolshed-anchor-register
branch
from
November 20, 2026 23:43
995fd47 to
dfb51b9
Compare
phlax
force-pushed
the
toolshed-anchor-register
branch
from
November 20, 2026 23:46
dfb51b9 to
52e5fcb
Compare
Use YAML anchors (supported in Actions since 2025-09) to pull every envoyproxy/toolshed action pin out of the job steps into one explicit register at the top of each workflow, aliased at the use sites. Bumping a pin is now a single edit in that file's register instead of one per occurrence. Anchors reuse whole nodes (not the SHA substring) and GitHub rejects unknown top-level keys, so each register rides an `env:` block; the `_TS_n` keys are throwaway anchor carriers (unused as env vars). Applied to all 7 workflows (15 pin sites): publish, _release, _verify_build, _verify_examples, _verify_filter, docs, releasing. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
toolshed-anchor-register
branch
from
November 20, 2026 23:48
52e5fcb to
34c375e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses YAML anchors (supported in GitHub Actions since 2025-09-18) to hoist every
envoyproxy/toolshedaction pin out of the job steps into one explicit register at the top of each workflow, aliased at each use site. Bumping a toolshed pin is now a single edit in that file's register instead of one per occurrence.Applied to all 7 workflows (15 pin sites):
publish,_release,_verify_build,_verify_examples,_verify_filter,docs,releasing.Constraints this works within:
env:block; the_TS_nkeys are throwaway anchor carriers (unused as environment variables — the&anchornames are the real identifiers).<<:) — unsupported by GitHub, not needed here.Validated locally: every alias resolves to the full pinned string, longest line ≤134 (
.yamllintmax 140), yamllint clean. CI confirms GitHub's parser accepts anenv-defined anchor aliased intouses:, andglint/lint pass.