Repository navigation
Return False from async text filters when the message has no text - #2650
Merged
Merged
Conversation
eternnoir#2645 added the 'no text' guard to the sync TextContainsFilter, TextStartsFilter and IsDigitFilter, and an older change added it to the sync TextFilter. The asyncio_filters versions still raise on a message with neither text nor caption, which aborts the remaining handlers for that update.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the async text-filter changes.
No open issues 🎉
What changed in this PR
Aligns async text filters with their synchronous counterparts so messages without text return False instead of raising exceptions, allowing dispatch to continue to later handlers.
Changes:
- Adds
Nonechecks to four async text filters while preservingTextFiltercaption matching. - Adds regression tests for messages without text and successful text or caption matches.
| File | Description |
|---|---|
tests/test_custom_filters.py |
Tests async filters with missing text and valid text or captions. |
telebot/asyncio_filters.py |
Returns False when the four async text filters have no text to match. |
Review effort: Balanced
Collaborator
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#2645 made the sync
TextContainsFilter,TextStartsFilterandIsDigitFilterreturn False when the message has no text, and the syncTextFilteralready did. Theasyncio_filtersversions still raise on such a message (TypeError: argument of type 'NoneType' is not iterable,AttributeError: 'NoneType' object has no attribute 'startswith', ...). InAsyncTeleBotthat exception skips the rest of the handlers for the update:A photo without a caption goes to the exception handler with a
TypeErrorinstead of reachingon_any_photo;TeleBotwith the same handlers callson_any_photo. This adds the sameNonechecks to the four async filters.Describe your tests
Two tests in
tests/test_custom_filters.py, next to the sync ones from #2645, using its fixtures; the first fails without the change.cd tests && py.test: 309 passed, 73 skipped (the token-dependent tests).Python version: 3.11 and 3.14
OS: Linux
Checklist:
Written with AI assistance (Claude); I have reviewed the change.