Repository navigation
fix: Sync-flush gzip so flushed stream data reaches the client - #134
Merged
Merged
Conversation
GzipCoding.encode returned a GZIPOutputStream without syncFlush, so flush() only flushed the underlying socket and left everything written so far inside the deflater. A streamed response (e.g. application/x-ndjson) that flushed an event delivered only the 10-byte gzip header to a client sending Accept-Encoding: gzip, until the deflater's buffer filled or the stream closed. Progressive and long-poll streams stalled. Create the GZIPOutputStream with syncFlush so a flush writes everything so far in a decodable form. Whole bodies are coded without a flush, so they pay nothing for it. Document the flush contract on ContentCoding.encode and in the README. Add GzipCodingTest covering flush output and a closed-stream round trip, and a GzipIT test that a flushed event of a gzipped stream reaches the client before the stream ends.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GzipCoding.encode returned a GZIPOutputStream without syncFlush, so flush() only flushed the underlying socket and left everything written so far inside the deflater. A streamed response (e.g. application/x-ndjson) that flushed an event delivered only the 10-byte gzip header to a client sending Accept-Encoding: gzip, until the deflater's buffer filled or the stream closed. Progressive and long-poll streams stalled.
Create the GZIPOutputStream with syncFlush so a flush writes everything so far in a decodable form. Whole bodies are coded without a flush, so they pay nothing for it. Document the flush contract on ContentCoding.encode and in the README.
Add GzipCodingTest covering flush output and a closed-stream round trip, and a GzipIT test that a flushed event of a gzipped stream reaches the client before the stream ends.