Skip to content

Fix mod updater game-branch compatibility - #622

Merged
fank merged 4 commits into
masterfrom
codex/fix-mod-version-compatibility
Nov 3, 2026
Merged

fank merged 4 commits into
masterfrom
codex/fix-mod-version-compatibility

Conversation

@fank

@fank fank commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Match mod factorio_version to the exact game major.minor, retaining the 0.18-to-1.0 exception and missing-field default of 0.12.
  • Make the updater safe to source without running updates or changing shell options.
  • Add five focused Bats tests for compatibility, release selection and base patch requirements, legacy defaults, safe sourcing, and normal script execution.
  • Run Bats in the existing regression CI job. No new Python tests or README changes.

Closes #613.

Validation

  • All five Bats tests pass locally with Bats 1.11.0.
  • Restoring the old version-selection logic in a temporary copy makes three regression tests fail as expected.
  • All 21 existing regression methods pass.
  • ShellCheck, actionlint, and whitespace checks pass.
  • Remote CI for this commit is not yet verified.

Comment thread docker/files/update-mods.sh Resolved
@fank
fank marked this pull request as ready for review November 3, 2026 14:44
@fank
fank merged commit fbf2425 into master Nov 3, 2026
@fank
fank deleted the codex/fix-mod-version-compatibility branch November 3, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mod updater does not reject incompatible versions correctly

1 participant