Skip to content

Remove remaining gsutil mentions - #1933

Merged
a-maurice merged 1 commit into
mainfrom
am-gsutil
Oct 9, 2026
Merged

a-maurice merged 1 commit into
mainfrom
am-gsutil

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Remove the remaining references to gsutil in comments and the function name. The function isn't actually used, but has useful information, so leaving it there.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Oct 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates references from the deprecated gsutil tool to gcloud storage across several scripts, including docstrings, comments, and renaming the function get_gsutil_tips to get_gcloud_storage_tips. There are no review comments, and I have no feedback to provide.

@a-maurice
a-maurice requested a review from AustinBenoit October 8, 2026 23:50
@a-maurice
a-maurice merged commit 33cac73 into main Oct 9, 2026
39 of 55 checks passed
@a-maurice
a-maurice deleted the am-gsutil branch October 9, 2026 21:41
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @a-maurice on commit 33cac73
Last updated: Fri Oct 9 16:26 PDT 2026
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected
storage [TEST] [ERROR] [Windows] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Oct 9, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants