Repository navigation
Add additional timeouts on handling incoming/outgoing connections - #191
Merged
Merged
Conversation
ameba23
marked this pull request as draft
October 15, 2026 10:31
ameba23
marked this pull request as ready for review
October 30, 2026 11:32
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the HTTP proxy setup deadline changes.
No open issues 🎉
What changed in this PR
Adds 60-second setup deadlines to HTTP proxy connections, preventing stalled setup attempts without limiting established connection lifetimes.
Changes:
- Bounds outgoing TCP, TLS, attestation, and HTTP setup; startup timeouts return an error, while reconnects retry with exponential backoff.
- Times out incoming TLS and attestation exchanges.
- Adds timeout regression tests and documents the behavior.
| File | Description |
|---|---|
README.md |
Documents setup deadlines and timeout behavior. |
crates/attested-tls/src/lib.rs |
Corrects a spelling error in a comment. |
crates/attested-tls-proxy/src/http/mod.rs |
Implements setup timeouts, adds a timeout error, and tests stalled peers and reconnect retries. |
crates/attested-tls-proxy/Cargo.toml |
Enables Tokio test utilities for time-controlled tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 60-second deadline for HTTP proxy connection setup, covering TCP, TLS, attestation, and HTTP initialization.
Startup timeouts return an error.
Reconnect timeouts retry with exponential backoff.
Incoming TLS and attestation exchanges also time out after 60 seconds.