Repository navigation
Bump attested-tls repo depdencies and pin them - #193
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The DCAP and cryptographic dependency upgrades require human validation because upstream code is unavailable and mocked tests do not establish real TDX/Azure attestation compatibility.
No open issues 🎉
What changed in this PR
Updates the attested TLS dependencies and pins them to commit ca2a75d3de428543947cf1272b425c5ca2c534d3, adapting local error handling to the upstream API change.
Changes:
- Pins
attestationandpccsto the same upstream revision. - Uses
AttestedTlsErrorfor report-input errors and adds tests for empty and malformed certificate chains. - Refreshes the lockfile with updated transitive dependencies.
| File | Description |
|---|---|
crates/attested-tls/src/lib.rs |
Updates error types, adds X.509 parse-error conversion, and tests invalid certificate chains. |
crates/attested-tls/Cargo.toml |
Pins production and test attestation dependencies. |
crates/attested-tls-proxy/Cargo.toml |
Pins the pccs dependency. |
Cargo.lock |
Records pinned Git revisions and updated dependency versions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps dependencies from the flashbots/attested-tls repo and updates for very minor api change. It also pins those dependencies to a specific commit (current head of main).