Repository navigation
test(server-config): cover saving the Solid server settings - #14
Merged
Merged
Conversation
The v0.1.0 release changes saveServerConfig to read the request with core-api's inputArray(), and Codecov's patch check failed with that line uncovered. The test saves settings over the defaults into SQLite. This package's dev install has no laravel/framework, so the test supplies guarded stand-ins for the Foundation traits, FormRequest, config() and response().
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v0.1.0 #14 +/- ##
====================================================
+ Coverage 26.49% 26.84% +0.35%
Complexity 643 643
====================================================
Files 19 19
Lines 2265 2265
====================================================
+ Hits 600 608 +8
+ Misses 1665 1657 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codecov/patch fails on #13: 0.00% of the diff hit against an auto target of 26.49%. The release's only source change is in
SolidController::saveServerConfig, where$request->array('server')became$request->inputArray('server'). No test runs any controller in this package.This adds two tests for
saveServerConfig:servervalues are merged overconfig('solid.server')and stored as thesystem.solid.serversetting;They run against in-memory SQLite and core-api's real
inputArray()macro.The package's dev install has the
illuminate/*components core-api needs, but notlaravel/framework. So core-api's base controller,FormRequest,config()andresponse()can't load in tests. The test defines guarded stand-ins for them, used only when the real ones are missing.Locally, all 110 tests pass and php-cs-fixer is clean.