Repository navigation
Re-enable flame.test with fix for material_ui 1.8.0 - #509
Merged
Merged
Conversation
Closed
6 tasks done
justinmc
approved these changes
Oct 21, 2026
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 . Thanks for the quick work here unblocking the tree and landing the yak shave fix!
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-flutter__flutter
that referenced
this pull request
Oct 21, 2026
Follow-up to flutter#194886. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` for `material_ui` 1.8.0, and flutter/tests#509 (`39874535bcc16e86286fa634e0479c0ec85ce1ae`) re-enabled `registry/flame.test` in `flutter/tests`. This rolls `dev/customer_testing/tests.version` to `39874535bcc16e86286fa634e0479c0ec85ce1ae`. Fixes flutter#194883
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Oct 22, 2026
Follow-up to flutter#194886. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` for `material_ui` 1.8.0, and flutter/tests#509 (`39874535bcc16e86286fa634e0479c0ec85ce1ae`) re-enabled `registry/flame.test` in `flutter/tests`. This rolls `dev/customer_testing/tests.version` to `39874535bcc16e86286fa634e0479c0ec85ce1ae`. Fixes flutter#194883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #508.
flame-engine/flame#4125 (
69b0968f97e3fdc07b3f19a44ba0df5a01a53d04) updatedgame_widget_lifecycle_test.dartinflame-engine/flameto disable route-transition snapshotting (FadeForwardsPageTransitionsBuilder(allowSnapshotting: false)) formaterial_ui1.8.0.This re-enables
registry/flame.testand updates the pinnedflamerevision to69b0968f97e3fdc07b3f19a44ba0df5a01a53d04.Part of flutter/flutter#194883