Repository navigation
fix(package_info_plus): declare file timestamp API in privacy manifests - #4027
Open
jihanurrahman33 wants to merge 1 commit into
Conversation
The iOS and macOS plugins read NSFileCreationDate (Documents directory) and fileModificationDate (bundle path) to report install and update times. Both are File Timestamp APIs that need a required-reason declaration, but the iOS manifest had an empty NSPrivacyAccessedAPITypes and the macOS manifest had no such key. Declare NSPrivacyAccessedAPICategoryFileTimestamp with reason C617.1 in both. Fixes fluttercommunity#3627 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The iOS and macOS implementations read two File Timestamp APIs to report install and update times:
NSFileCreationDateon the Documents directory (install time)fileModificationDateon the bundle path (update time)These need a required-reason declaration, but the iOS
PrivacyInfo.xcprivacyhad an emptyNSPrivacyAccessedAPITypesand the macOS one had no such key. This PR declaresNSPrivacyAccessedAPICategoryFileTimestampwith reasonC617.1in both manifests. Packaging (Package.swift and the podspecs) already bundles the manifests, so only their contents change.Open question for reviewers:
C617.1clearly covers the Documents-directory call, but the bundlefileModificationDatecall reads outside the app's data container. I'm happy to switch to or add a different reason code if you prefer.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR. (No Dart code changed; not run.)Testing note: I confirmed both manifests parse as valid plists and contain the intended entry. I have not yet built the example app or checked Xcode's privacy report with CocoaPods or SwiftPM, so a maintainer check on that would be appreciated.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).🤖 Generated with Claude Code